Skip to content

Replace GIDSignInCallback - #179

Merged
Alex-4-Git merged 5 commits into
GIDGoogleUser-restructurefrom
pin-ReplaceGIDSignInCallback
Jul 16, 2022
Merged

Replace GIDSignInCallback#179
Alex-4-Git merged 5 commits into
GIDGoogleUser-restructurefrom
pin-ReplaceGIDSignInCallback

Conversation

@Alex-4-Git

@Alex-4-GitAlex-4-Git commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Replace GIDSignInCallback with block void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)

@Alex-4-Git
Replace GIDSignInCallback
174e6b8
Replace GIDSignInCallback with block
void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
@Alex-4-Git
Change GIDSignInCallback in sample apps.
5d23b41
mdmathias
mdmathias requested changes Jul 12, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
@Alex-4-Git
Minor improvements
31133ab
1. Resolve comments
2. Make sure in clients callback one of userAuth and error is nil.
petea
petea suggested changes Jul 13, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
Comment threadGoogleSignIn/Sources/GIDSignIn.m
@Alex-4-Git
Alex-4-Git requested a review from peteaJuly 13, 2022 22:17
petea
petea suggested changes Jul 14, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
Comment threadGoogleSignIn/Sources/GIDSignIn.m Outdated
Comment threadGoogleSignIn/Sources/GIDSignIn.m Outdated
Comment threadGoogleSignIn/Sources/GIDSignIn.m Outdated
Comment threadGoogleSignIn/Sources/GIDSignIn.m Outdated
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-ReplaceGIDSignInCallback branch from d885189 to b0dc952CompareJuly 15, 2022 16:42
@Alex-4-Git
Alex-4-Git requested a review from peteaJuly 15, 2022 20:08
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-ReplaceGIDSignInCallback branch from b0dc952 to 2059e64CompareJuly 15, 2022 21:28
petea
petea approved these changes Jul 15, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDSignIn.m Outdated

@peteapeteaJul 15, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space before {

@Alex-4-GitAlex-4-GitJul 16, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment threadGoogleSignIn/Sources/GIDSignIn.m Outdated

@peteapeteaJul 15, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest renaming this GIDUserAuthCallback and moving it to GIDSignIn_Private.h so that you can use it in GIDSignInInternalOptions and elsewhere.

@Alex-4-GitAlex-4-GitJul 16, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Alex-4-Git
Alex-4-Gitforce-pushed the pin-ReplaceGIDSignInCallback branch from 2059e64 to ba214ceCompareJuly 16, 2022 05:40
@Alex-4-Git
Alex-4-Git merged commit cc7eece into GIDGoogleUser-restructureJul 16, 2022
Alex-4-Git added a commit that referenced this pull request Aug 3, 2022
@Alex-4-Git
Replace GIDSignInCallback (#179)
1f54000
Replace GIDSignInCallback with block
void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
Alex-4-Git added a commit that referenced this pull request Aug 3, 2022
@Alex-4-Git
Replace GIDSignInCallback (#179)
71f82c0
Replace GIDSignInCallback with block
void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
Alex-4-Git added a commit that referenced this pull request Aug 3, 2022
@Alex-4-Git
Replace GIDSignInCallback (#179)
3ba23d0
Replace GIDSignInCallback with block
void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
Alex-4-Git added a commit that referenced this pull request Aug 3, 2022
@Alex-4-Git
Replace GIDSignInCallback (#179)
ada3203
Replace GIDSignInCallback with block
void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
Alex-4-Git added a commit that referenced this pull request Aug 11, 2022
@Alex-4-Git
Replace GIDSignInCallback (#179)
03d6d8d
Replace GIDSignInCallback with block
void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
Alex-4-Git added a commit that referenced this pull request Aug 11, 2022
@Alex-4-Git
Replace GIDSignInCallback (#179)
fcb8692
Replace GIDSignInCallback with block
void (^)(GIDUserAuth *_Nullable userAuth, NSError *_Nullable error)
@w-goog
w-goog deleted the pin-ReplaceGIDSignInCallback branch March 5, 2026 00:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathiasmdmathiasmdmathias approved these changes
+1 more reviewer
@peteapeteapetea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alex-4-Git@petea@mdmathias