Skip to content

Add the property configuration to GIDGoogleUser - #183

Merged
Alex-4-Git merged 3 commits into
GIDGoogleUser-restructurefrom
pin-removeGIDAuth
Jul 25, 2022
Merged

Add the property configuration to GIDGoogleUser#183
Alex-4-Git merged 3 commits into
GIDGoogleUser-restructurefrom
pin-removeGIDAuth

Conversation

@Alex-4-Git

@Alex-4-GitAlex-4-Git commented Jul 20, 2022

Copy link
Copy Markdown
Contributor
  • Add a GIDConfiguration to replace hostedDomain, serverClientID, openRealm.
  • Remove the property serverAuthCode.

@Alex-4-Git
Alex-4-Gitforce-pushed the pin-removeGIDAuth branch 2 times, most recently from 3f7b666 to 4feeee7CompareJuly 20, 2022 02:03
@Alex-4-Git
Add the property GIDConfiguration to GIDGoogleUser
0ff9492
- Add a GIDConfiguration to replace hostedDomain, serverClientID, openRealm.
- Remove the property serverAuthCode.
mdmathias
mdmathias reviewed Jul 20, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUser+Testing.m
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m
petea
petea suggested changes Jul 21, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
@peteapetea changed the title Add the property GIDConfiguration to GIDGoogleUser Add the property configuration to GIDGoogleUserJul 22, 2022
petea
petea suggested changes Jul 22, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUser+Testing.m
@Alex-4-Git
Alex-4-Git requested a review from peteaJuly 22, 2022 20:51
petea
petea suggested changes Jul 22, 2022
View reviewed changes
Comment thread.swiftpm/xcode/xcshareddata/xcschemes/GoogleSignIn-UnitTests.xcscheme Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
petea
petea suggested changes Jul 25, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
petea
petea suggested changes Jul 25, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
@Alex-4-Git
Alex-4-Git merged this pull request into GIDGoogleUser-restructureJul 25, 2022
Alex-4-Git added a commit that referenced this pull request Aug 3, 2022
@Alex-4-Git
Add the propertyconfigurationtoGIDGoogleUser(#183)
be4f6fa
* Add the property GIDConfiguration to GIDGoogleUser
- Add a GIDConfiguration to replace hostedDomain, serverClientID, openRealm.
- Remove the property serverAuthCode.
Alex-4-Git added a commit that referenced this pull request Aug 3, 2022
@Alex-4-Git
Add the propertyconfigurationtoGIDGoogleUser(#183)
e5958f8
* Add the property GIDConfiguration to GIDGoogleUser
- Add a GIDConfiguration to replace hostedDomain, serverClientID, openRealm.
- Remove the property serverAuthCode.
Alex-4-Git added a commit that referenced this pull request Aug 11, 2022
@Alex-4-Git
Add the propertyconfigurationtoGIDGoogleUser(#183)
42bf359
* Add the property GIDConfiguration to GIDGoogleUser
- Add a GIDConfiguration to replace hostedDomain, serverClientID, openRealm.
- Remove the property serverAuthCode.
@Alex-4-Git
Alex-4-Git deleted the pin-removeGIDAuth branch August 26, 2022 00:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathiasmdmathiasmdmathias approved these changes
+1 more reviewer
@peteapeteapetea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alex-4-Git@petea@mdmathias