Skip to content

Rename callback blocks to completion to support Swift async and await - #187

Merged
mdmathias merged 1 commit into
mainfrom
mdmathias/async-support
Aug 1, 2022
Merged

Rename callback blocks to completion to support Swift async and await#187
mdmathias merged 1 commit into
mainfrom
mdmathias/async-support

Conversation

@mdmathias

@mdmathiasmdmathias commented Jul 27, 2022

Copy link
Copy Markdown
Collaborator

Fixes#91

@mdmathiasmdmathias changed the title Rename callback blocks to completion to support Swift's async and awaitRename callback blocks to completion to support Swifts async and awaitJul 27, 2022
@mdmathiasmdmathias changed the title Rename callback blocks to completion to support Swifts async and awaitRename callback blocks to completion to support Swift async and awaitJul 27, 2022
petea
petea reviewed Jul 27, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDAuthentication.h Outdated
@mdmathias
mdmathiasforce-pushed the mdmathias/async-support branch 2 times, most recently from 722a199 to fc6a3eaCompareJuly 28, 2022 22:42
@mdmathias
mdmathias marked this pull request as ready for review August 1, 2022 19:16
petea
petea reviewed Aug 1, 2022
View reviewed changes

@peteapetea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to include related changes to DaysUntilBirthday here?

@petea

petea commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

Did you intend to include related changes to DaysUntilBirthday here?

n/m, I see #190 now.

petea
petea approved these changes Aug 1, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDAuthentication.h Outdated
Alex-4-Git
Alex-4-Git reviewed Aug 1, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDSignIn.m Outdated
@mdmathias
mdmathiasforce-pushed the mdmathias/async-support branch 2 times, most recently from 8d52267 to b183c4dCompareAugust 1, 2022 21:33
@mdmathias
mdmathiasforce-pushed the mdmathias/async-support branch from b183c4d to c98e4c5CompareAugust 1, 2022 21:36
@mdmathias
mdmathias merged commit e46e0cb into mainAug 1, 2022
mdmathias added a commit that referenced this pull request Aug 18, 2022
@mdmathias
Revert "Rename callback blocks to completion to support Swift async a…
d3a4b4f
…nd await (#187)"
This reverts commit e46e0cb.
mdmathias added a commit that referenced this pull request Aug 18, 2022
@mdmathias
Temporarily revert breaking API changes for 6.2.3 patch release (#200)
59c32cf
* Revert "Rename callback blocks to completion to support Swift async and await (#187)"
This reverts commit e46e0cb.
* Revert "Fix Sample App build failure (#195)"
This reverts commit ab78228.
@peteapetea added this to the 7.0.0 milestone Sep 7, 2022
@peteapetea mentioned this pull request Sep 7, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Alex-4-GitAlex-4-GitAlex-4-Git left review comments
@peteapeteapetea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@peteapetea

Labels

None yet

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Enable automatic async/await API generation

3 participants

@mdmathias@petea@Alex-4-Git