Skip to content

Improve doc comment for GIDSignInButtonStyle - #204

Merged
w-goog merged 5 commits into
google:mainfrom
kamimi01:feature/fix-document-comments
Mar 11, 2026
Merged

Improve doc comment for GIDSignInButtonStyle#204
w-goog merged 5 commits into
google:mainfrom
kamimi01:feature/fix-document-comments

Conversation

@kamimi01

Copy link
Copy Markdown
Contributor

I worked on #203

I think to be customizable the display text is better than adding document comments like this, so this is a workaround.

@peteapetea linked an issue Aug 22, 2022 that may be closed by this pull request
@peteapetea changed the title fix: Document comment for GIDSignInButtonStyleImprove doc comment for GIDSignInButtonStyleAug 22, 2022
@kamimi01

Copy link
Copy Markdown
ContributorAuthor

@petea Hi team,
Thank you for checking my pull request. As I mentioned, I think to be customizable display text is better than adding doc comments. Do you have a plan to be able to customize it? If you don't, would you mind telling me a reason?
Thank you.

Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDSignInButton.h Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDSignInButton.h Outdated
@w-goog
w-goog merged commit 8483591 into google:mainMar 11, 2026
13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix document comment of GoogleSignIn (product "GoogleSignIn")

3 participants

@kamimi01@monicakh@w-goog