Skip to content

Add unit test for updateAuthState: in GIDGoogleUserTest - #212

Merged
Alex-4-Git merged 6 commits into
GIDGoogleUser-restructurefrom
pin-addTestForUpdateAuthState
Sep 19, 2022
Merged

Add unit test for updateAuthState: in GIDGoogleUserTest#212
Alex-4-Git merged 6 commits into
GIDGoogleUser-restructurefrom
pin-addTestForUpdateAuthState

Conversation

@Alex-4-Git

@Alex-4-GitAlex-4-Git commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

Our plan is to merge GIDAuthentication into GIDGoogleUser. This PR is to add more coverage to exiting GIDGoogleUser API and prepare for more changes in the coming PRs.

mdmathias
mdmathias reviewed Sep 7, 2022
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
@Alex-4-Git
Restructures unit tests
4433f5f
- Adds a new initializer in OIDAuthState+Testing.
- Renames unclear constants.
- Makes the unit tests more descriptive and understandable.
petea
petea reviewed Sep 8, 2022
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
mdmathias
mdmathias reviewed Sep 9, 2022
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
mdmathias
mdmathias reviewed Sep 10, 2022
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
mdmathias
mdmathias reviewed Sep 17, 2022
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m
@Alex-4-Git
Alex-4-Git merged commit 3e54f09 into GIDGoogleUser-restructureSep 19, 2022
@Alex-4-Git
Alex-4-Git deleted the pin-addTestForUpdateAuthState branch September 19, 2022 20:54
@Alex-4-Git
Alex-4-Git restored the pin-addTestForUpdateAuthState branch September 21, 2022 18:15
@w-goog
w-goog deleted the pin-addTestForUpdateAuthState branch March 5, 2026 00:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathiasmdmathiasmdmathias approved these changes
@peteapeteaAwaiting requested review from petea

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alex-4-Git@petea@mdmathias