Skip to content

Make tokens in GIDGoogleUser KVO-compliant - #222

Merged
Alex-4-Git merged 9 commits into
GIDGoogleUser-restructurefrom
pin-AddKVOInGoogleUser
Sep 26, 2022
Merged

Make tokens in GIDGoogleUser KVO-compliant#222
Alex-4-Git merged 9 commits into
GIDGoogleUser-restructurefrom
pin-AddKVOInGoogleUser

Conversation

@Alex-4-Git

@Alex-4-GitAlex-4-Git commented Sep 20, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

To be consistent with GIDAuthentication, the token properties in GIDGoogleUser should be KVO-compliant.

@Alex-4-Git
Add KVO in GIDGoogleUser
30699df
Send KVO notifications when authState updates tokens.
@Alex-4-Git
Observe KVO in GIDGoogleUserTest
9ac5478
Uses bit mask to verify KVO notifications are sent.
petea
petea reviewed Sep 22, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m
petea
petea suggested changes Sep 22, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
@Alex-4-Git
Remove the KVO testing
d45e398
Since we use NSObject automatic change notifications we can remove the tests for manual notifications emission.
petea
petea suggested changes Sep 23, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m
@Alex-4-Git
Test tokens unchanged
9d5f7db
Added a new test case `testUpdateAuthState_tokensAreNotChanged `
petea
petea approved these changes Sep 26, 2022
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
@Alex-4-Git
Alex-4-Git merged commit 405dc51 into GIDGoogleUser-restructureSep 26, 2022
@Alex-4-Git
Alex-4-Git deleted the pin-AddKVOInGoogleUser branch September 26, 2022 18:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathiasmdmathiasAwaiting requested review from mdmathias
1 more reviewer
@peteapeteapetea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alex-4-Git@petea