Skip to content

Add a configuration property populated via Info.plist - #228

Merged
petea merged 10 commits into
mainfrom
petea-config
Sep 29, 2022
Merged

Add a configuration property populated via Info.plist#228
petea merged 10 commits into
mainfrom
petea-config

Conversation

@petea

@peteapetea commented Sep 23, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Provide a new configuration property on GIDSignIn representing the active config.
  • Update the API surface to remove the GIDConfiguration parameter from the signIn method signatures.
  • Create a mechanism to automatically set the configuration property via Info.plist.

@petea
petea marked this pull request as ready for review September 26, 2022 23:33
mdmathias
mdmathias reviewed Sep 27, 2022
View reviewed changes
Comment threadSamples/Swift/DaysUntilBirthday/Shared/Services/GoogleSignInAuthenticator.swift Outdated
Alex-4-Git
Alex-4-Git reviewed Sep 27, 2022
View reviewed changes
Comment threadSamples/Swift/DaysUntilBirthday/Shared/Services/GoogleSignInAuthenticator.swift Outdated
Comment threadGoogleSignIn/Sources/GIDSignIn.m Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h
Comment threadGoogleSignIn/Tests/Unit/GIDFakeMainBundle.m Outdated
@peteapetea changed the title Provide configuration via Info.plistAdd a configuration property populated via Info.plistSep 27, 2022
mdmathias
mdmathias reviewed Sep 28, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDSignIn.m Outdated
mdmathias
mdmathias reviewed Sep 29, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDSignIn.m
@petea
petea merged commit ae5276c into mainSep 29, 2022
@petea
petea deleted the petea-config branch September 29, 2022 20:38
@peteapetea added this to the 7.0.0 milestone Nov 2, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathiasmdmathiasmdmathias approved these changes
+1 more reviewer
@Alex-4-GitAlex-4-GitAlex-4-Git approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@petea@mdmathias@Alex-4-Git