Skip to content

Move the fetcher authorizer into GIDGoogleUser API - #230

Merged
Alex-4-Git merged 20 commits into
GIDGoogleUser-restructurefrom
pin-moveFetcherAuthorizaer
Oct 3, 2022
Merged

Move the fetcher authorizer into GIDGoogleUser API#230
Alex-4-Git merged 20 commits into
GIDGoogleUser-restructurefrom
pin-moveFetcherAuthorizaer

Conversation

@Alex-4-Git

@Alex-4-GitAlex-4-Git commented Sep 26, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

This is the part of the refactor plan - merge GIDAuthentication into GIDGoogleUser.

  • Move fetcherAuthorizer into GIDGoogleUser public API.
  • Move associated classes and methods into GIDGoogleUser.m.

Alex-4-Gitand others added 10 commits September 19, 2022 17:55
@Alex-4-Git
Add KVO in GIDGoogleUser
30699df
Send KVO notifications when authState updates tokens.
@Alex-4-Git
Observe KVO in GIDGoogleUserTest
9ac5478
Uses bit mask to verify KVO notifications are sent.
@Alex-4-Git
Utilize the class extension and automatic KVO notifications
26784fe
@Alex-4-Git
Merge branch 'GIDGoogleUser-restructure' into pin-AddKVOInGoogleUser
f2b0a5f
@Alex-4-Git
Only update tokens if necessary
6e5d21a
@Alex-4-Git
Merge branch 'pin-AddKVOInGoogleUser' ofhttps://github.com/google/Go…
9f32608
…ogleSignIn-iOS into pin-AddKVOInGoogleUser
@Alex-4-Git
Remove the KVO testing
d45e398
Since we use NSObject automatic change notifications we can remove the tests for manual notifications emission.
@Alex-4-Git
Test tokens unchanged
a56786b
Added a new test case `testUpdateAuthStateWithUnchangedRefreshTokenAndIDToken `
@Alex-4-Git
Move fetcherAuthorizer from GIDAuthentication to GIDGoogleUser
58d2acf
@Alex-4-Git
Merge branch 'GIDGoogleUser-restructure' into pin-moveFetcherAuthorizaer
f843c57
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-moveFetcherAuthorizaer branch 2 times, most recently from 3f26081 to 296c45cCompareSeptember 27, 2022 00:16
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-moveFetcherAuthorizaer branch from 296c45c to 3d29212CompareSeptember 27, 2022 17:29
petea
petea suggested changes Sep 28, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
mdmathias
mdmathias reviewed Sep 28, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
@Alex-4-Git
Alex-4-Git marked this pull request as draft September 28, 2022 22:39
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-moveFetcherAuthorizaer branch from 056b1a9 to ad40f6cCompareSeptember 29, 2022 01:51
@Alex-4-Git
Alex-4-Git marked this pull request as ready for review September 29, 2022 02:10
mdmathias
mdmathias reviewed Sep 29, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDAppAuthFetcherAuthorizationWithEMMSupport.m Outdated
@mdmathiasmdmathias mentioned this pull request Sep 29, 2022
Open
@mdmathiasmdmathias mentioned this pull request Sep 29, 2022
Open
petea
petea suggested changes Sep 30, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDAppAuthFetcherAuthorizationWithEMMSupport.h
Comment threadGoogleSignIn/Sources/GIDAppAuthFetcherAuthorizationWithEMMSupport.m
Comment threadGoogleSignIn/Sources/GIDAppAuthFetcherAuthorizationWithEMMSupport.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDAppAuthFetcherAuthorizationWithEMMSupport.h Outdated
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-moveFetcherAuthorizaer branch from 1c015f3 to 51bb424CompareOctober 1, 2022 20:19
@Alex-4-Git
Alex-4-Git requested a review from peteaOctober 2, 2022 18:12
XiangtianDai
XiangtianDai reviewed Oct 3, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDEMMSupport.m Outdated
Comment threadGoogleSignIn/Sources/GIDAuthentication_Private.h
petea
petea approved these changes Oct 3, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDAppAuthFetcherAuthorizationWithEMMSupport.m Outdated
@Alex-4-Git
Alex-4-Git merged commit 64b35f8 into GIDGoogleUser-restructureOct 3, 2022
@Alex-4-Git
Alex-4-Git deleted the pin-moveFetcherAuthorizaer branch October 3, 2022 22:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathiasmdmathiasmdmathias approved these changes
@XiangtianDaiXiangtianDaiAwaiting requested review from XiangtianDai
+2 more reviewers
@dav3yblaz3dav3yblaz3dav3yblaz3 left review comments
@peteapeteapetea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Alex-4-Git@petea@mdmathias@XiangtianDai@dav3yblaz3