Skip to content

Move the method doWithFreshTokens: into GIDGoogleUserAPI - #234

Merged
Alex-4-Git merged 30 commits into
GIDGoogleUser-restructurefrom
pin-moveDoWithFreshTokens
Oct 14, 2022
Merged

Move the method doWithFreshTokens: into GIDGoogleUserAPI#234
Alex-4-Git merged 30 commits into
GIDGoogleUser-restructurefrom
pin-moveDoWithFreshTokens

Conversation

@Alex-4-Git

@Alex-4-GitAlex-4-Git commented Oct 4, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR moves the doWithFreshTokens into GIDGoogleUser which is the last part in GIDAuthentication. The main modifications are as follows.

  • Move doWithFreshTokens: into GIDGoogleUser.
  • Keep GIDAuthentication internally to test encoding backward compatibility.
  • Introduce id<OIDAuthStateChangeDelegate> in GIDGoogleUser to observe the OIDAuthState changes.

Alex-4-Gitand others added 23 commits September 19, 2022 17:55
@Alex-4-Git
Add KVO in GIDGoogleUser
30699df
Send KVO notifications when authState updates tokens.
@Alex-4-Git
Observe KVO in GIDGoogleUserTest
9ac5478
Uses bit mask to verify KVO notifications are sent.
@Alex-4-Git
Utilize the class extension and automatic KVO notifications
26784fe
@Alex-4-Git
Merge branch 'GIDGoogleUser-restructure' into pin-AddKVOInGoogleUser
f2b0a5f
@Alex-4-Git
Only update tokens if necessary
6e5d21a
@Alex-4-Git
Merge branch 'pin-AddKVOInGoogleUser' ofhttps://github.com/google/Go…
9f32608
…ogleSignIn-iOS into pin-AddKVOInGoogleUser
@Alex-4-Git
Remove the KVO testing
d45e398
Since we use NSObject automatic change notifications we can remove the tests for manual notifications emission.
@Alex-4-Git
Test tokens unchanged
a56786b
Added a new test case `testUpdateAuthStateWithUnchangedRefreshTokenAndIDToken `
@Alex-4-Git
Move fetcherAuthorizer from GIDAuthentication to GIDGoogleUser
58d2acf
@Alex-4-Git
Merge branch 'GIDGoogleUser-restructure' into pin-moveFetcherAuthorizaer
f843c57
@Alex-4-Git
Move fetcherAuthorizer into GIDGoogleUser API
3d29212
@Alex-4-Git
Create GIDAppAuthFetcherAuthorizationWithEMMSupport class
ca97c30
@Alex-4-Git
Minor improvements.
ad40f6c
@Alex-4-Git
Update GIDAppAuthFetcherAuthorizationWithEMMSupport.m
bd3257d
@Alex-4-Git
Create fetcherAuthorizer at initialization
f87f063
@Alex-4-Git
Fix test failures
9f9f85a
@Alex-4-Git
Suppress the deprecation warnings.
c622c97
@Alex-4-Git
Added Utility class GIDEMMSupport to handle EMM related issues.
51bb424
@Alex-4-Git
Minor improvement.
befe977
@Alex-4-Git
Move doWithFreshTokens: into GIDGoogleUser API
33705b4
@Alex-4-Git
Merge branch 'GIDGoogleUser-restructure' into pin-moveDoWithFreshTokens
0102dc6
@Alex-4-Git
Minor improvement
846f4ce
@Alex-4-Git
Add unit tests
70bc182
- Add GIDEMMSupportTest
- Add test cases for `doWithFreshTokens:`in GIDGoogleUserTest
- Delete GIDAuthenticationTest
@Alex-4-Git
Alex-4-Git marked this pull request as ready for review October 6, 2022 20:07
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-moveDoWithFreshTokens branch from bc07103 to ee6f7a4CompareOctober 6, 2022 20:48
petea
petea suggested changes Oct 7, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadSamples/Swift/DaysUntilBirthday/Shared/Services/BirthdayLoader.swift
ch40w31
ch40w31 reviewed Oct 7, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-moveDoWithFreshTokens branch 2 times, most recently from 4065709 to 8b241e6CompareOctober 7, 2022 23:58
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-moveDoWithFreshTokens branch from 8b241e6 to b9f312aCompareOctober 8, 2022 00:22
petea
petea suggested changes Oct 10, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m
@Alex-4-Git
Alex-4-Git requested a review from peteaOctober 11, 2022 05:57
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-moveDoWithFreshTokens branch from 3ff1fa5 to 6ee3073CompareOctober 12, 2022 21:51
ch40w31
ch40w31 requested changes Oct 13, 2022
View reviewed changes

@ch40w31ch40w31 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also check the PR description?

  • GIDAuthentication is now preserved for testing purpose.
  • Not sure what "Introduce id in GIDGoogleUser to observe the OIDAuthState changes" means.

Comment threadGoogleSignIn/Sources/GIDAuthentication.m Outdated
Comment threadGoogleSignIn/Sources/GIDAuthentication.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUser+Testing.h Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUser+Testing.m
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUser+Testing.h Outdated
ch40w31
ch40w31 requested changes Oct 13, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-moveDoWithFreshTokens branch from 35be9ec to c065b29CompareOctober 13, 2022 22:44
@Alex-4-Git
Alex-4-Git merged commit e43bd7f into GIDGoogleUser-restructureOct 14, 2022
@Alex-4-Git
Alex-4-Git deleted the pin-moveDoWithFreshTokens branch October 14, 2022 00:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ch40w31ch40w31ch40w31 approved these changes
@mdmathiasmdmathiasAwaiting requested review from mdmathias
@peteapeteaAwaiting requested review from petea

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alex-4-Git@petea@ch40w31