Skip to content

Add unit tests for GIDEMMSupport - #236

Merged
Alex-4-Git merged 5 commits into
GIDGoogleUser-restructurefrom
pin-AddTestForGIDEMMSupport
Oct 10, 2022
Merged

Add unit tests for GIDEMMSupport#236
Alex-4-Git merged 5 commits into
GIDGoogleUser-restructurefrom
pin-AddTestForGIDEMMSupport

Conversation

@Alex-4-Git

@Alex-4-GitAlex-4-Git commented Oct 6, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

In the previous PR we created a utility class GIDEMMSupport to handle EMM related issues. This PR adds some unit tests for that class.

@Alex-4-Git
Alex-4-Git marked this pull request as ready for review October 6, 2022 21:02
petea
petea suggested changes Oct 7, 2022
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDEMMSupportTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDEMMSupportTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDEMMSupportTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDEMMSupportTest.m
Comment threadGoogleSignIn/Tests/Unit/GIDEMMSupportTest.m
Comment threadGoogleSignIn/Tests/Unit/GIDEMMSupportTest.m Outdated
ch40w31
ch40w31 reviewed Oct 7, 2022
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDEMMSupportTest.m Outdated
XiangtianDai
XiangtianDai reviewed Oct 7, 2022
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDEMMSupportTest.m Outdated
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-AddTestForGIDEMMSupport branch from f18eb79 to ff62ad7CompareOctober 8, 2022 00:18
petea
petea approved these changes Oct 10, 2022
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDEMMSupportTest.m Outdated
@Alex-4-Git
Alex-4-Git merged commit 18c65c0 into GIDGoogleUser-restructureOct 10, 2022
@Alex-4-Git
Alex-4-Git deleted the pin-AddTestForGIDEMMSupport branch October 10, 2022 21:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XiangtianDaiXiangtianDaiXiangtianDai approved these changes
@mdmathiasmdmathiasAwaiting requested review from mdmathias
@ch40w31ch40w31Awaiting requested review from ch40w31
+1 more reviewer
@peteapeteapetea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Alex-4-Git@petea@ch40w31@XiangtianDai