Skip to content

Move the method addScopes into GIDGoogleUser API - #239

Merged
Alex-4-Git merged 14 commits into
GIDGoogleUser-restructurefrom
pin-GIDGoogleUserAddScopes
Oct 28, 2022
Merged

Move the method addScopes into GIDGoogleUser API#239
Alex-4-Git merged 14 commits into
GIDGoogleUser-restructurefrom
pin-GIDGoogleUserAddScopes

Conversation

@Alex-4-Git

@Alex-4-GitAlex-4-Git commented Oct 14, 2022

Copy link
Copy Markdown
Contributor
  • add addScopes in GIDGoogleUser.h
  • move `addScopes' from GIDSignIn.h to GIDSignIn_Private.h

@Alex-4-Git
Alex-4-Git changed the base branch from main to GIDGoogleUser-restructureOctober 14, 2022 23:50
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-GIDGoogleUserAddScopes branch from 654a5fe to ba4095fCompareOctober 14, 2022 23:53
@Alex-4-Git
Alex-4-Git marked this pull request as ready for review October 17, 2022 18:48
mdmathias
mdmathias reviewed Oct 17, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDSignIn_Private.h Outdated
Comment threadSamples/Swift/DaysUntilBirthday/Shared/Services/GoogleSignInAuthenticator.swift
mdmathias
mdmathias approved these changes Oct 18, 2022
View reviewed changes

@mdmathiasmdmathias left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two little nits/questions. LGTM.

Comment threadGoogleSignIn/Sources/GIDSignIn_Private.h
Comment threadGoogleSignIn/Sources/GIDSignIn_Private.h Outdated
petea
petea suggested changes Oct 19, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
Comment threadGoogleSignIn/Sources/GIDSignIn_Private.h
Comment threadGoogleSignIn/Sources/GIDSignIn_Private.h Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m
Comment threadSamples/Swift/DaysUntilBirthday/Shared/Services/GoogleSignInAuthenticator.swift Outdated
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-GIDGoogleUserAddScopes branch from 5bfe213 to 12cb754CompareOctober 20, 2022 23:52
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-GIDGoogleUserAddScopes branch from 12cb754 to 8c4d954CompareOctober 21, 2022 00:05
@Alex-4-Git
Alex-4-Git requested a review from peteaOctober 21, 2022 00:24
petea
petea suggested changes Oct 25, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
Comment threadGoogleSignIn/Sources/GIDSignIn_Private.h Outdated
Comment threadGoogleSignIn/Sources/GIDSignIn_Private.h Outdated
Comment threadSamples/ObjC/SignInSample/Source/SignInViewController.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
ch40w31
ch40w31 requested changes Oct 25, 2022
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
ch40w31
ch40w31 reviewed Oct 26, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
petea
petea approved these changes Oct 28, 2022
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
ch40w31
ch40w31 reviewed Oct 28, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDGoogleUser.m Outdated
@Alex-4-Git
Alex-4-Git merged commit 114a0ac into GIDGoogleUser-restructureOct 28, 2022
@Alex-4-Git
Alex-4-Git deleted the pin-GIDGoogleUserAddScopes branch October 28, 2022 21:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ch40w31ch40w31ch40w31 approved these changes
@mdmathiasmdmathiasAwaiting requested review from mdmathias
+1 more reviewer
@peteapeteapetea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Alex-4-Git@petea@mdmathias@ch40w31