Skip to content

Rename the GIDGoogleUser method doWithFreshTokens: - #242

Merged
Alex-4-Git merged 10 commits into
GIDGoogleUser-restructurefrom
pin-renameDoWithFreshToken
Nov 2, 2022
Merged

Rename the GIDGoogleUser method doWithFreshTokens:#242
Alex-4-Git merged 10 commits into
GIDGoogleUser-restructurefrom
pin-renameDoWithFreshToken

Conversation

@Alex-4-Git

@Alex-4-GitAlex-4-Git commented Oct 18, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

The objc API method doWithFreshTokens translates into do in Swift which is not understandable well.
In this PR we change this to refreshTokensIfNeededWithCompletion so in Swift client can use it as refreshTokensIfNeeded(completion:)

@Alex-4-Git
Alex-4-Git changed the base branch from GIDGoogleUser-restructure to pin-GIDGoogleUserAddScopesOctober 18, 2022 17:53
@Alex-4-Git
Alex-4-Git changed the base branch from pin-GIDGoogleUserAddScopes to GIDGoogleUser-restructureOctober 18, 2022 17:54
@Alex-4-Git
Alex-4-Gitforce-pushed the pin-renameDoWithFreshToken branch from 2763167 to 30f938dCompareOctober 28, 2022 21:56
@Alex-4-Git
Alex-4-Git marked this pull request as ready for review October 28, 2022 22:19
petea
petea reviewed Oct 28, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
@Alex-4-Git
Alex-4-Git requested a review from peteaOctober 30, 2022 21:32
petea
petea reviewed Oct 31, 2022
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDGoogleUser.h Outdated
@Alex-4-Git
Alex-4-Git requested a review from peteaOctober 31, 2022 23:01
@peteapetea changed the title Rename the GIDGoogleUser API doWithFreshTokens:Rename the GIDGoogleUser method doWithFreshTokens:Nov 1, 2022
@Alex-4-Git
Alex-4-Git merged commit 828ea1f into GIDGoogleUser-restructureNov 2, 2022
@Alex-4-Git
Alex-4-Git deleted the pin-renameDoWithFreshToken branch November 2, 2022 18:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathiasmdmathiasmdmathias approved these changes
+1 more reviewer
@peteapeteapetea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alex-4-Git@petea@mdmathias