Skip to content

Fix the restorePreviousSignIn when completion is nil - #301

Merged
henryhl22321 merged 6 commits into
mainfrom
hengyul/bug-fix
May 4, 2023
Merged

Fix the restorePreviousSignIn when completion is nil#301
henryhl22321 merged 6 commits into
mainfrom
hengyul/bug-fix

Conversation

@henryhl22321

@henryhl22321henryhl22321 commented Apr 19, 2023

Copy link
Copy Markdown
Contributor

Return to void and not trigger the callback when the completion is nil.

ch40w31
ch40w31 requested changes Apr 20, 2023
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
mdmathias
mdmathias requested changes Apr 20, 2023
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
@mdmathias

mdmathias commented Apr 20, 2023

Copy link
Copy Markdown
Collaborator

@henryhl22321 you will need to rebase main here after #302 is merged. #302 is needed so that the workflows pass.

mdmathias
mdmathias requested changes Apr 26, 2023
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
mdmathias
mdmathias requested changes Apr 27, 2023
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m
mdmathias
mdmathias reviewed Apr 29, 2023
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
@henryhl22321henryhl22321 linked an issue May 2, 2023 that may be closed by this pull request
restorePreviousSignInWithCompletion() call crash if the completion is null #289
Closed
@henryhl22321
henryhl22321 merged commit 6a329cb into mainMay 4, 2023
@henryhl22321
henryhl22321 deleted the hengyul/bug-fix branch May 4, 2023 18:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathiasmdmathiasmdmathias approved these changes
@ch40w31ch40w31ch40w31 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

restorePreviousSignInWithCompletion() call crash if the completion is null

3 participants

@henryhl22321@mdmathias@ch40w31