Skip to content

Support using a debug app check provider during configuration - #336

Merged
mdmathias merged 29 commits into
mdmathias/app-attestfrom
mdmathias/configure-debug-provider
Sep 8, 2023
Merged

Support using a debug app check provider during configuration#336
mdmathias merged 29 commits into
mdmathias/app-attestfrom
mdmathias/configure-debug-provider

Conversation

@mdmathias

@mdmathiasmdmathias commented Aug 25, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Updates -[GIDSignIn configureWithCompletion:] to be -[GIDSignIn configureDebugProviderWithAPIKey:completion:] so that clients can specify using a debug app check provider (e.g., when running on the simulator).

andrewheard
andrewheard reviewed Aug 25, 2023
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.h Outdated
@mdmathias
mdmathias requested review from andrewheard and yalkhder and removed request for ch40w31August 25, 2023 20:54
andrewheard
andrewheard reviewed Aug 30, 2023
View reviewed changes
Comment threadSamples/Swift/AppAttestExample/AppAttestExample/AppAttestExampleApp.swift Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
andrewheard
andrewheard approved these changes Aug 30, 2023
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
andrewheard
andrewheard suggested changes Sep 5, 2023
View reviewed changes
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
yalkhder
yalkhder approved these changes Sep 8, 2023
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDAppCheckTest.m Outdated
andrewheard
andrewheard reviewed Sep 8, 2023
View reviewed changes

@andrewheardandrewheard left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @paulb777

Comment threadGoogleSignIn/Sources/GIDAppCheck/Implementations/Fake/GIDAppCheckProviderFake.m
Comment threadGoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.h Outdated
Comment threadGoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
Comment threadGoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m Outdated
andrewheard
andrewheard approved these changes Sep 8, 2023
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDAppCheck/Implementations/Fake/GIDAppCheckProviderFake.h Outdated
@mdmathias
mdmathias merged commit 847af57 into mdmathias/app-attestSep 8, 2023
@mdmathias
mdmathias deleted the mdmathias/configure-debug-provider branch September 8, 2023 23:28
mdmathias added a commit that referenced this pull request Apr 10, 2024
@mdmathias
Support using a debug app check provider during configuration (#336)
d966409
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yalkhderyalkhderyalkhder approved these changes
+1 more reviewer
@andrewheardandrewheardandrewheard approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdmathias@yalkhder@andrewheard