Skip to content

Add support for GTMAppAuth 5 on macOS - #522

Merged
camden-king merged 15 commits into
mainfrom
camden-king/GTMAppAuth-v5-mac-support
May 20, 2025
Merged

Add support for GTMAppAuth 5 on macOS#522
camden-king merged 15 commits into
mainfrom
camden-king/GTMAppAuth-v5-mac-support

Conversation

@camden-king

@camden-kingcamden-king commented May 13, 2025

Copy link
Copy Markdown
Contributor

This PR make the changes for GTMAppAuth v5 to work on iOS, specifically:

  1. Added entitlements to days until birthday for macOS.
  2. Updates documentation that $(AppIdentifierPrefix)$(CFBundleIdentifier) must be added as an access group for macOS apps.
  3. Adds migration logic on macOS to migrate keys stored using GTMAppAuth < v5.

brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDAuthStateMigration.m Outdated
brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDAuthStateMigration.m Outdated
brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDAuthStateMigration.m Outdated
brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDSignIn.m Outdated
brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated
brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated
brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated
brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated
brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated
brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated
brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated
brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated
brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated
brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated
brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadREADME.md Outdated
brnnmrls
brnnmrls reviewed May 14, 2025
View reviewed changes
Comment threadREADME.md
brnnmrls
brnnmrls reviewed May 20, 2025
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDAuthStateMigration.m
brnnmrls
brnnmrls reviewed May 20, 2025
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDAuthStateMigration.m Outdated
brnnmrls
brnnmrls reviewed May 20, 2025
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDAuthStateMigration.m
brnnmrls
brnnmrls reviewed May 20, 2025
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDAuthStateMigrationTest.m Outdated
brnnmrls
brnnmrls reviewed May 20, 2025
View reviewed changes

@brnnmrlsbrnnmrls left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits to clean up, otherwise looks pretty good to me!

@camden-king
camden-king merged commit 9e8be62 into mainMay 20, 2025
@camden-king
camden-king deleted the camden-king/GTMAppAuth-v5-mac-support branch May 20, 2025 22:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brnnmrlsbrnnmrlsbrnnmrls approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camden-king@brnnmrls