Create GIDFakeAuthStateMigration - #529

Merged

camden-king merged 16 commits into

camden-king/migration-bug-fixesfrom

camden-king/create-GIDAuthStateMigrationFake

Jun 18, 2025

camden-king commented Jun 6, 2025

Contributor

This PR creates GIDFakeAuthStateMigration and uses in GIDSignInTest.

camden-king changed the base branch from main to camden-king/migration-bug-fixes

June 6, 2025 17:41

camden-king marked this pull request as ready for review

June 6, 2025 20:21

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDSignIn.m Outdated

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDSignIn.m Outdated

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDSignIn.m

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDSignIn.m Outdated

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDAuthStateMigration/Fake/GIDFakeAuthStateMigration.m Outdated

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Tests/Unit/GIDSignInTest.m

brnnmrls commented Jun 10, 2025

Member

Might be worth rerunning/checking on the pod-lib-lint errors.

camden-kingand others added 13 commits

June 17, 2025 16:22

create fake

0974883

Revert "only attempt migrations one time"

e5b86b5

This reverts commit fd0a5a8.

update fake and create test

b5d9e45

update fake and create test

31e8734

remove unneeded local variable from GIDSignIn

a52d83b

Attempt migrations once (#528)

4397dd6

changes from review

7a301c1

update comment + spacing

4d0707a

check signIn not nil

6ef11d8

Update GIDAuthStateMigration to not perform migration when built for …

69058b6

…Mac Catalyst (#526)

update fake and create test

645e281

rebase

7b9bac0

rebase

26a118a

camden-king force-pushed the camden-king/create-GIDAuthStateMigrationFake branch from 5595d18 to 26a118aCompare

June 17, 2025 23:27

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDSignIn.m Outdated

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDSignIn.m Outdated

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDSignIn.m Outdated

changes from review

59d1172

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDSignIn_Private.h Outdated

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDSignIn_Private.h Outdated

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDAuthStateMigration/Implementation/GIDAuthStateMigration.m

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDAuthStateMigration/Fake/GIDFakeAuthStateMigration.m Outdated

brnnmrls reviewed

View reviewed changes

GoogleSignIn/Sources/GIDAuthStateMigration/Fake/GIDFakeAuthStateMigration.m

camden-king added 2 commits

June 18, 2025 11:20

changes from review

e56d34f

removed line break

1181124

brnnmrls approved these changes

View reviewed changes

camden-king merged commit e81db5b into camden-king/migration-bug-fixes

camden-king deleted the camden-king/create-GIDAuthStateMigrationFake branch

June 18, 2025 19:47

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment