Skip to content

Support Swift6 version to Birthday sample app. - #544

Merged
w-goog merged 1 commit into
google:mainfrom
khetiSubrat:swit6birthdaysampleapp
Aug 20, 2025
Merged

Support Swift6 version to Birthday sample app.#544
w-goog merged 1 commit into
google:mainfrom
khetiSubrat:swit6birthdaysampleapp

Conversation

@khetiSubrat

@khetiSubratkhetiSubrat commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Support Swift6 version to Birthday sample app.

@google-cla

google-claBot commented Aug 12, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

w-goog
w-goog requested changes Aug 12, 2025
View reviewed changes

@w-googw-goog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this! One small change requested, then we should be good to go :)

(Note: We'll explicitly support Swift 6 in the repo soon, at which point some of these changes may be reverted)

Comment threadSamples/Swift/DaysUntilBirthday/Shared/Services/UserProfileImageLoader.swift Outdated
@khetiSubrat
khetiSubratforce-pushed the swit6birthdaysampleapp branch from 23afeb9 to 5446939CompareAugust 13, 2025 05:29
w-goog
w-goog approved these changes Aug 14, 2025
View reviewed changes

@w-googw-goog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally by pulling in these changes, and they look good. Thank you for making them! :)

@w-goog

w-goog commented Aug 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Apologies for the delay, updating our Github actions to fix the tests :) This PR can be merged once #545 is complete.

@w-goog
w-googforce-pushed the swit6birthdaysampleapp branch from 5446939 to 4e59d85CompareAugust 20, 2025 19:21
@w-goog
w-goog merged commit 0bd7587 into google:mainAug 20, 2025
12 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@w-googw-googw-goog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khetiSubrat@w-goog