Skip to content

GIDTokenClaimsInternalOptions Implementation + Unit Tests #550 - #552

Merged
AkshatG6 merged 7 commits into
gandhiakshat/sbc-auth_timefrom
gandhiakshat/sbc-token_claims-internal-options
Sep 9, 2025
Merged

GIDTokenClaimsInternalOptions Implementation + Unit Tests #550#552
AkshatG6 merged 7 commits into
gandhiakshat/sbc-auth_timefrom
gandhiakshat/sbc-token_claims-internal-options

Conversation

@AkshatG6

@AkshatG6AkshatG6 commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

This pull request introduces the GIDTokenClaimsInternalOptions class, which focuses on validating the claims and converting these claims into a JSON object.

Key changes:

Adds the GIDTokenClaimsInternalOptions class to validate the requested claims.
Provides unit tests to validate the implementation.

@AkshatG6
AkshatG6force-pushed the gandhiakshat/sbc-token_claims-internal-options branch from 2922722 to 1b43e18CompareSeptember 5, 2025 19:59
mdmathias
mdmathias requested changes Sep 6, 2025
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDTokenClaimsInternalOptions.h
Comment threadGoogleSignIn/Sources/GIDTokenClaimsInternalOptions.h Outdated
Comment threadGoogleSignIn/Sources/GIDTokenClaimsInternalOptions.h Outdated
Comment threadGoogleSignIn/Sources/GIDTokenClaimsInternalOptions.m Outdated
Comment threadGoogleSignIn/Sources/GIDTokenClaimsInternalOptions.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDTokenClaimsInternalOptionsTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDTokenClaimsInternalOptionsTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDTokenClaimsInternalOptionsTest.m
Comment threadGoogleSignIn/Tests/Unit/GIDTokenClaimsInternalOptionsTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDTokenClaimsInternalOptionsTest.m Outdated
mdmathias
mdmathias requested changes Sep 9, 2025
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDTokenClaimsInternalOptionsTest.m
Comment threadGoogleSignIn/Tests/Unit/GIDTokenClaimsInternalOptionsTest.m
Comment threadGoogleSignIn/Tests/Unit/GIDTokenClaimsInternalOptionsTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDTokenClaimsInternalOptionsTest.m Outdated
mdmathias
mdmathias reviewed Sep 9, 2025
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDTokenClaimsInternalOptionsTest.m Outdated
@AkshatG6
AkshatG6 merged commit 51868b3 into gandhiakshat/sbc-auth_timeSep 9, 2025
12 checks passed
@AkshatG6
AkshatG6 deleted the gandhiakshat/sbc-token_claims-internal-options branch September 9, 2025 20:11
@brnnmrlsbrnnmrls mentioned this pull request Jan 7, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathiasmdmathiasmdmathias approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AkshatG6@mdmathias