Skip to content

Update AddScopes to include previously requested tokenClaims in the… - #557

Merged
AkshatG6 merged 6 commits into
gandhiakshat/sbc-auth_timefrom
gandhiakshat/sbc-auth_time-update-add-scopes
Sep 23, 2025
Merged

Update AddScopes to include previously requested tokenClaims in the…#557
AkshatG6 merged 6 commits into
gandhiakshat/sbc-auth_timefrom
gandhiakshat/sbc-auth_time-update-add-scopes

Conversation

@AkshatG6

@AkshatG6AkshatG6 commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

This pull request improves the AddScopes flow to include tokenClaims that were requested during the last authentication request.

mdmathias
mdmathias reviewed Sep 22, 2025
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDSignIn.m
mdmathias
mdmathias reviewed Sep 22, 2025
View reviewed changes
Comment threadGoogleSignIn/Sources/GIDSignIn.m Outdated
mdmathias
mdmathias requested changes Sep 22, 2025
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
mdmathias
mdmathias approved these changes Sep 23, 2025
View reviewed changes
Comment threadGoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
@AkshatG6
AkshatG6 merged commit 5a0d207 into gandhiakshat/sbc-auth_timeSep 23, 2025
12 checks passed
@AkshatG6
AkshatG6 deleted the gandhiakshat/sbc-auth_time-update-add-scopes branch September 23, 2025 23:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathiasmdmathiasmdmathias approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AkshatG6@mdmathias