Skip to content

docs: too many E(inv=2, role=user) plus reformatting - #3538

Closed
adrianad wants to merge 3 commits into
google:mainfrom
adrianad:patch-1
Closed

docs: too many E(inv=2, role=user) plus reformatting#3538
adrianad wants to merge 3 commits into
google:mainfrom
adrianad:patch-1

Conversation

@adrianad

Copy link
Copy Markdown
Contributor

Main change from:
E(inv=2, role=user), E(inv=2, role=model), E(inv=2, role=user),

To:
E(inv=2, role=user), E(inv=2, role=model)

I think the last E(inv=2, role=user) was wrong. Also reformatted.

Main change from:
E(inv=2, role=user), E(inv=2, role=model), E(inv=2, role=user),
To:
E(inv=2, role=user), E(inv=2, role=model)
I think the last E(inv=2, role=user) was wrong. Also reformatted.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @adrianad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the documentation for the _run_compaction_for_sliding_window function. It addresses a minor inaccuracy in an example sequence of events by removing a redundant entry and simultaneously improves the readability of these examples through consistent reformatting. The changes aim to provide clearer and more accurate explanatory comments for future reference.

Highlights

  • Documentation Correction: An erroneous E(inv=2, role=user) entry was removed from the example session content in the _run_compaction_for_sliding_window function's documentation, ensuring accuracy.
  • Readability Improvement: The example session content within the documentation was reformatted to enhance its readability and visual presentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an error in the docstring example for event compaction and improves its formatting for better readability. The core change is accurate and enhances the documentation. I've added a couple of minor suggestions to remove trailing whitespace for code cleanliness.

Comment threadsrc/google/adk/apps/compaction.py Outdated
Comment threadsrc/google/adk/apps/compaction.py Outdated
@rohityanrohityan self-assigned this Nov 13, 2025
hangfeiand others added 2 commits November 13, 2025 13:23
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@rohityan

Copy link
Copy Markdown
Collaborator

Hi @adrianad, Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share.

@rohityanrohityan added the documentation [Component] This issue is related to documentation, it will be transferred to adk-docs label Nov 14, 2025
copybara-serviceBot pushed a commit that referenced this pull request Nov 21, 2025
Merge #3538
Main change from:
E(inv=2, role=user), E(inv=2, role=model), E(inv=2, role=user),
To:
E(inv=2, role=user), E(inv=2, role=model)
I think the last E(inv=2, role=user) was wrong. Also reformatted.
Co-authored-by: Hangfei Lin <hangfei@google.com>
COPYBARA_INTEGRATE_REVIEW=#3538 from adrianad:patch-1 627b933
PiperOrigin-RevId: 835346467
@adk-bot

Copy link
Copy Markdown
Collaborator

Thank you @adrianad for your contribution! 🎉

Your changes have been successfully imported and merged via Copybara in commit 609c617.

Closing this PR as the changes are now in the main branch.

@adk-botadk-bot closed this Nov 21, 2025
sarojrout pushed a commit to sarojrout/adk-python that referenced this pull request Nov 27, 2025
Merge google#3538
Main change from:
E(inv=2, role=user), E(inv=2, role=model), E(inv=2, role=user),
To:
E(inv=2, role=user), E(inv=2, role=model)
I think the last E(inv=2, role=user) was wrong. Also reformatted.
Co-authored-by: Hangfei Lin <hangfei@google.com>
COPYBARA_INTEGRATE_REVIEW=google#3538 from adrianad:patch-1 627b933
PiperOrigin-RevId: 835346467
FrigaZzz pushed a commit to FrigaZzz/adk-python that referenced this pull request Aug 11, 2026
Merge google#3538
Main change from:
E(inv=2, role=user), E(inv=2, role=model), E(inv=2, role=user),
To:
E(inv=2, role=user), E(inv=2, role=model)
I think the last E(inv=2, role=user) was wrong. Also reformatted.
Co-authored-by: Hangfei Lin <hangfei@google.com>
COPYBARA_INTEGRATE_REVIEW=google#3538 from adrianad:patch-1 627b933
PiperOrigin-RevId: 835346467
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation[Component] This issue is related to documentation, it will be transferred to adk-docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@adrianad@rohityan@adk-bot@hangfei