Skip to content

Disable scheduled GitHub Actions workflows in forks - #4059

Closed
ftnext wants to merge 1 commit into
google:mainfrom
ftnext:disable-fork-actions
Closed

Disable scheduled GitHub Actions workflows in forks#4059
ftnext wants to merge 1 commit into
google:mainfrom
ftnext:disable-fork-actions

Conversation

@ftnext

Copy link
Copy Markdown
Contributor

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

Problem:
Excessive notifications from periodic workflow runs (every 6 hours for triage, daily for stale-bot and docs upload) in forks where they are not needed.

Solution:
Add repository checks to prevent scheduled workflows from running in forked repositories.
The workflows will now only run in the main google/adk-python repository.

Testing Plan

I think that unit tests and E2E are not needed because this change is for GitHub Actions (not ADK source code).

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@adk-botadk-bot added the tools [Component] This issue is related to tools label Jan 1, 2026
@rohityanrohityan self-assigned this Jan 6, 2026
@rohityan

Copy link
Copy Markdown
Collaborator

Hi @ftnext , Thank you for your contribution! We appreciate you taking the time to submit this pull request.

@rohityan

Copy link
Copy Markdown
Collaborator

Hi @wuliang229 , can you please review this. LGTM.

@rohityanrohityan added the needs review [Status] The PR/issue is awaiting review from the maintainer label Jan 8, 2026
@wuliang229
wuliang229 self-requested a review January 15, 2026 00:12
@wuliang229wuliang229 removed the tools [Component] This issue is related to tools label Jan 15, 2026
Add repository checks to prevent scheduled workflows from running
in forked repositories. This prevents excessive notifications from
periodic workflow runs (every 6 hours for triage, daily for stale-bot
and docs upload) in forks where they are not needed.
The workflows will now only run in the main google/adk-python repository.
@wuliang229wuliang229 added the ready to pull [Status] This PR is ready to be imported back to Google label Jan 15, 2026
copybara-serviceBot pushed a commit that referenced this pull request Jan 15, 2026
Merge #4059
### Link to Issue or Description of Change
**1. Link to an existing issue (if applicable):**
- Closes: #3961
**Problem:**
Excessive notifications from periodic workflow runs (every 6 hours for triage, daily for stale-bot and docs upload) in forks where they are not needed.
**Solution:**
Add repository checks to prevent scheduled workflows from running in forked repositories.
The workflows will now only run in the main google/adk-python repository.
### Testing Plan
I think that unit tests and E2E are not needed because this change is for GitHub Actions (not ADK source code).
_Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes._
**Unit Tests:**
- [ ] I have added or updated unit tests for my change.
- [ ] All unit tests pass locally.
_Please include a summary of passed `pytest` results._
**Manual End-to-End (E2E) Tests:**
_Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix._
### Checklist
- [x] I have read the [CONTRIBUTING.md](https://github.com/google/adk-python/blob/main/CONTRIBUTING.md) document.
- [x] I have performed a self-review of my own code.
- [x] I have commented my code, particularly in hard-to-understand areas.
- [ ] I have added tests that prove my fix is effective or that my feature works.
- [ ] New and existing unit tests pass locally with my changes.
- [ ] I have manually tested my changes end-to-end.
- [ ] Any dependent changes have been merged and published in downstream modules.
COPYBARA_INTEGRATE_REVIEW=#4059 from ftnext:disable-fork-actions 991cc94
PiperOrigin-RevId: 856691019
@adk-bot

Copy link
Copy Markdown
Collaborator

Thank you @ftnext for your contribution! 🎉

Your changes have been successfully imported and merged via Copybara in commit 50c4b8d.

Closing this PR as the changes are now in the main branch.

@adk-botadk-bot closed this Jan 15, 2026
@rohityanrohityan removed the needs review [Status] The PR/issue is awaiting review from the maintainer label Jan 20, 2026
FrigaZzz pushed a commit to FrigaZzz/adk-python that referenced this pull request Aug 11, 2026
Merge google#4059
### Link to Issue or Description of Change
**1. Link to an existing issue (if applicable):**
- Closes: google#3961
**Problem:**
Excessive notifications from periodic workflow runs (every 6 hours for triage, daily for stale-bot and docs upload) in forks where they are not needed.
**Solution:**
Add repository checks to prevent scheduled workflows from running in forked repositories.
The workflows will now only run in the main google/adk-python repository.
### Testing Plan
I think that unit tests and E2E are not needed because this change is for GitHub Actions (not ADK source code).
_Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes._
**Unit Tests:**
- [ ] I have added or updated unit tests for my change.
- [ ] All unit tests pass locally.
_Please include a summary of passed `pytest` results._
**Manual End-to-End (E2E) Tests:**
_Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix._
### Checklist
- [x] I have read the [CONTRIBUTING.md](https://github.com/google/adk-python/blob/main/CONTRIBUTING.md) document.
- [x] I have performed a self-review of my own code.
- [x] I have commented my code, particularly in hard-to-understand areas.
- [ ] I have added tests that prove my fix is effective or that my feature works.
- [ ] New and existing unit tests pass locally with my changes.
- [ ] I have manually tested my changes end-to-end.
- [ ] Any dependent changes have been merged and published in downstream modules.
COPYBARA_INTEGRATE_REVIEW=google#4059 from ftnext:disable-fork-actions 991cc94
PiperOrigin-RevId: 856691019
@ftnext
ftnext deleted the disable-fork-actions branch August 15, 2026 08:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull[Status] This PR is ready to be imported back to Google

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow fails when automatically executed on forks

4 participants

@ftnext@rohityan@adk-bot@wuliang229