Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for handling
db_pathwhen it starts with/is to remove the leading slash. This implies that absolute paths are expected to be provided without the leading slash when passed toSqliteMemoryService. While this works, it might be more intuitive to handle bothsqlite:///path/to/dbandsqlite:////abs/path/to/db(whichurlparsewould parse as/abs/path/to/db) consistently by ensuringdb_pathis correctly interpreted as an absolute path if it starts with/after parsing, rather than stripping it. However, given the currentSqliteMemoryServiceexpectsdb_pathto be astrorPathand handlesPathobjects correctly, stripping the leading slash might be fine ifSqliteMemoryServiceinternally resolves relative paths from the current working directory or if thedb_pathis always expected to be relative unless explicitly handled as absolute by the caller.