Skip to content

docs: update ToolboxTool docstring - #7

Merged
hangfei merged 3 commits into
google:mainfrom
jackwotherspoon:main
Apr 11, 2025
Merged

docs: update ToolboxTool docstring#7
hangfei merged 3 commits into
google:mainfrom
jackwotherspoon:main

Conversation

@jackwotherspoon

@jackwotherspoonjackwotherspoon commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

Update port for ToolboxTool to match default port used for Toolbox server of 5000.

ToolboxTool is missing from tools.__init__.py:

__all__= [
'APIHubToolset',
'AuthToolArguments',
'BaseTool',
'built_in_code_execution',
'google_search',
'VertexAiSearchTool',
'ExampleTool',
'exit_loop',
'FunctionTool',
'get_user_choice',
'load_artifacts',
'load_memory',
'LongRunningFunctionTool',
'preload_memory',
'ToolContext',
'transfer_to_agent',
]

This means users need to use the full import path for ToolboxTool .

fromgoogle.adk.tools.toolbox_toolimportToolboxTool

This also means ToolboxTool will be excluded from being imported when users import all tools.

fromgoogle.adk.toolsimport*

Adding ToolboxTool to tools.__init__.py makes it easier for customers to leverage MCP Toolbox for databases.

fromgoogle.adk.toolsimportToolboxTool

Once this change is released we ca update the ToolboxTool imports in the docs back to their original form.

Example:
```python
toolbox = ToolboxTool("http://127.0.0.1:8080")
toolbox = ToolboxTool("http://127.0.0.1:5000")

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pentium10

Copy link
Copy Markdown

how do you start this toolbox?

@jackwotherspoon

Copy link
Copy Markdown
ContributorAuthor

how do you start this toolbox?

@pentium10ToolboxTool is for loading tools for MCP Toolbox for Databases. You can find a walkthrough in the ADK docs here.

You start it by installing and running the toolbox server.

@fhinkel

Copy link
Copy Markdown

Unfortunately, that would add toolbox_langchain as a dependency. But I like the fix for the port!

@jackwotherspoon

Copy link
Copy Markdown
ContributorAuthor

Unfortunately, that would add toolbox_langchain as a dependency. But I like the fix for the port!

Ahh great point. I had not noticed toolbox_langchain was not a core dep 🙃

@jackwotherspoonjackwotherspoon changed the title chore: add ToolboxTool to tools.__init__.pydocs: update ToolboxTool docstringApr 10, 2025
@hangfei
hangfei merged commit 59117b9 into google:mainApr 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core[Component] This issue is related to the core interface and implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@jackwotherspoon@pentium10@fhinkel@Jacksunwei@josegonzalesjjg@selcukgun@hangfei