Skip to content

fix: dtype parameter ineffective in Series/DataFrame construction - #1354

Merged
chelsea-lin merged 4 commits into
mainfrom
main_chelsealin_dtypebugs
Feb 5, 2025
Merged

fix: dtype parameter ineffective in Series/DataFrame construction#1354
chelsea-lin merged 4 commits into
mainfrom
main_chelsealin_dtypebugs

Conversation

@chelsea-lin

@chelsea-linchelsea-lin commented Feb 3, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Corrects an issue where the dtype parameter was not being applied in some cases during Series and DataFrame construction.

  • Fixes internal issue 394086695 and 362738764🦕
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 394086695 and 362738764 🦕

@product-auto-labelproduct-auto-labelBot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 3, 2025
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_dtypebugs branch from c0a3ec0 to df43fe8CompareFebruary 3, 2025 21:54
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Feb 3, 2025
@chelsea-linchelsea-lin changed the title fix: dtype parameter ineffective in Series IOfix: dtype parameter ineffective in Series/DataFrame IOFeb 3, 2025
@chelsea-linchelsea-lin changed the title fix: dtype parameter ineffective in Series/DataFrame IOfix: dtype parameter ineffective in Series/DataFrame constructionFeb 3, 2025
@chelsea-lin
chelsea-lin marked this pull request as ready for review February 3, 2025 21:59
@chelsea-lin
chelsea-lin requested review from a teamFebruary 3, 2025 21:59
@chelsea-lin

chelsea-lin commented Feb 3, 2025

Copy link
Copy Markdown
ContributorAuthor

test_series_construct_w_dtype_for_array_string fails on system-3-9 but works in python 3.12

@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_dtypebugs branch from f0246f7 to 69b2701CompareFebruary 5, 2025 00:34
tswast
tswast reviewed Feb 5, 2025
View reviewed changes
Comment threadtests/system/small/test_series.py
Comment threadtests/system/small/test_series.py
@chelsea-lin
chelsea-lin enabled auto-merge (squash) February 5, 2025 18:24
@chelsea-lin
chelsea-lin merged commit b9bdca8 into mainFeb 5, 2025
@chelsea-lin
chelsea-lin deleted the main_chelsealin_dtypebugs branch February 5, 2025 19:14
@release-pleaserelease-pleaseBot mentioned this pull request Feb 5, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswasttswast approved these changes
@Genesis929Genesis929Awaiting requested review from Genesis929

Assignees

@shobsishobsi

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chelsea-lin@tswast@shobsi