Skip to content

docs: update bq_dataframes_llm_output_schema.ipynb - #2004

Merged
tswast merged 22 commits into
google:mainfrom
ccarpentiere:output_schema
Oct 31, 2025
Merged

docs: update bq_dataframes_llm_output_schema.ipynb#2004
tswast merged 22 commits into
google:mainfrom
ccarpentiere:output_schema

Conversation

@ccarpentiere

@ccarpentiereccarpentiere commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass.
  • [N/A] Code coverage does not decrease (if any source code was changed)
  • [N/A] Appropriate docs were updated (if necessary)

Fixes#2000 🦕

Unit tests for Python 3.12 passed, notebook works when tested in the console.

@ccarpentiere
ccarpentiere requested review from a team and jialuooAugust 18, 2025 20:16
@review-notebook-app

review-notebook-appBot commented Aug 18, 2025

Copy link
Copy Markdown

Check out this pull request on ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 18, 2025
@ccarpentiereccarpentiere changed the title Update bq_dataframes_llm_output_schema.ipynbdocs: update bq_dataframes_llm_output_schema.ipynbAug 18, 2025
sycai
sycai reviewed Aug 18, 2025
View reviewed changes
Comment threadnotebooks/generative_ai/bq_dataframes_llm_output_schema.ipynb Outdated
" </a>\n",
" </td>\n",
" <td>\n",
" <a href=\"https://github.com/googleapis/python-bigquery-dataframes/blob/main/notebooks/generative_ai/bq_dataframes_llm_output_schema.ipynb\">\n",

@sycaisycaiAug 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use a Vertext AI Workbench link instead of a Github link?

@ccarpentiereccarpentiereAug 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had added that option in, and I just removed it again. It isn't really needed, since we want users to open the notebook in BigQuery.

@tswast
tswast enabled auto-merge (squash) October 30, 2025 21:42
@tswasttswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 31, 2025
@gcf-owl-botgcf-owl-botBot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 31, 2025
@tswast
tswast merged commit 316ba9f into google:mainOct 31, 2025
20 checks passed
@release-pleaserelease-pleaseBot mentioned this pull request Oct 30, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswastAwaiting requested review from tswast
2 more reviewers
@sycaisycaisycai approved these changes
@jialuoojialuoojialuoo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jiaxunwujiaxunwu

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Edit bq_dataframes_llm_output_schema.ipynb for clarity and completeness

5 participants

@ccarpentiere@sycai@jialuoo@tswast@jiaxunwu