fix: Improve Anywidget pagination and display for unknown row counts by shuoweil · Pull Request #2258 · google/bigframes

shuoweil · 2025-11-12T03:08:16Z

Previously, when the total number of rows (row_count) was unknown (e.g., due to deferred computation or errors), it would incorrectly default to 0. This resulted in confusing UI, such as displaying "Page 1 of 0", and allowed users to navigate to empty pages without automatically returning to valid data.

current display strategy for the interactive table widget:

When row_count is a positive number (e.g., 50):
- Total Rows Display: Shows the exact count, like 50 total rows.
- Pagination Display: Shows the page relative to the total rows, like Page 1 of 50.
- Navigation: The "Next" button is disabled only on the final page.
When row_count is None (unknown):
- Total Rows Display: Shows Total rows unknown.
- Pagination Display: Shows the page relative to an unknown total, like Page 1 of many.
- Navigation: The "Next" button is always enabled, allowing you to page forward until the backend determines there is no more data.

Fixes #<452747934> 🦕

review-notebook-app · 2025-11-12T03:08:21Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

…-count

tswast · 2025-11-17T17:41:39Z

+ # If row count is unknown, allow any non-negative page
+ if self.row_count is None:
+ return max(0, value)


What are the cases where we would expect to get a negative value?
I suspect we may want to raise an exception because it indicates some bad state has been entered. Better to show an error than to continue in a bad state.

It is a safe guard, when system has a glitches. I agree with you, I change to an error catch for negative numbers.

tswast · 2025-11-17T17:57:46Z

 # there are multiple pages and show "page 1 of many" in this case
 self._reset_batches_for_new_page_size()
 if self._batches is None or self._batches.total_rows is None:
+ # TODO(b/428238610): We could still end up with a None here if the


This bug is marked as fixed. Is there other context for what action is needed? Also, as a TODO, I'm not sure what the intended update to the code would be. Is this just supposed to be a comment?

I have removed TODO. The code is updated to differentiate between a failure to get any batches at all and successfully getting batches (a true error) but not having a known total row count (an expected condition for the "page X of many" display).

tswast · 2025-11-17T17:58:34Z

 if self._batches is None or self._batches.total_rows is None:
+ # TODO(b/428238610): We could still end up with a None here if the
+ # underlying execution doesn't produce a total row count.
 self._error_message = "Could not determine total row count. Data might be unavailable or an error occurred."


Could we separate total rows and batches None? As stated in the comment above none for total_rows is expected, not an error.

This is a good point. I have updated the logic to separate these tow conditions.
The code now sets an _error_message if _batches itself is None, which indicates a true failure to retrieve data. The case where _batches.total_rows is None is not handled as the expected state for an unknown row count, and no error message is generated. This aligns with your suggestion.

…-count

shuoweil · 2025-11-18T18:23:33Z

@tswast Upon checking, the failed e2e tests are not related to my change.

tswast

Thank you!

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620 <details><summary>bigframes: 2.30.0</summary> ## [2.30.0](v2.29.0...v2.30.0) (2025-12-03) ### Features * Support mixed scalar-analytic expressions (#2239) ([20ab469](20ab469d)) * Allow drop_duplicates over unordered dataframe (#2303) ([52665fa](52665fa5)) * Preserve source names better for more readable sql (#2243) ([64995d6](64995d65)) * use end user credentials for `bigframes.bigquery.ai` functions when `connection_id` is not present (#2272) ([7c062a6](7c062a68)) * pivot_table supports fill_value arg (#2257) ([8f490e6](8f490e68)) * Support builtins funcs for df.agg (#2256) ([956a5b0](956a5b00)) * add bigquery.json_keys (#2286) ([b487cf1](b487cf1f)) * Add agg/aggregate methods to windows (#2288) ([c4cb39d](c4cb39dc)) * Add bigframes.pandas.crosstab (#2231) ([c62e553](c62e5535)) * Implement single-column sorting for interactive table widget (#2255) ([d1ecc61](d1ecc61b)) ### Bug Fixes * Pass credentials properly for read api instantiation (#2280) ([3e3fe25](3e3fe259)) * Update max_instances default to reflect actual value (#2302) ([4489687](4489687e)) * Improve Anywidget pagination and display for unknown row counts (#2258) ([508deae](508deae5)) * Fix issue with stream upload batch size upload limit (#2290) ([6cdf64b](6cdf64b0)) * calling info() on empty dataframes no longer leads to errors (#2267) ([95a83f7](95a83f77)) * do not warn with DefaultIndexWarning in partial ordering mode (#2230) ([cc2dbae](cc2dbae6)) ### Documentation * update docs and tests for Gemini 2.5 models (#2279) ([08c0c0c](08c0c0c8)) * Add Google Analytics configuration to conf.py (#2301) ([0b266da](0b266da1)) * fix LogisticRegression docs rendering (#2295) ([32e5313](32e53134)) * update API reference to new `dataframes.bigquery.dev` location (#2293) ([da06439](da064397)) * use autosummary to split documentation pages (#2251) ([f7fd2d2](f7fd2d20)) </details>

fix: Improve Anywidget pagination and display for unknown row counts
c23d9ce

shuoweil requested a review from tswast November 12, 2025 03:08

shuoweil self-assigned this Nov 12, 2025

shuoweil requested review from a teamNovember 12, 2025 03:08

product-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 12, 2025

shuoweil added 4 commits November 12, 2025 18:57

Merge branch 'main' into shuowei-anywidget-fallback-unknown-total-row…
037d0b6
…-count

testcase update
0fe2cd7

Merge branch 'main' into shuowei-anywidget-fallback-unknown-total-row…
b2c99a2
…-count

display page 1 of many
88c451e

product-auto-labelBot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Nov 13, 2025

shuoweil added 3 commits November 14, 2025 05:32

Merge branch 'main' into shuowei-anywidget-fallback-unknown-total-row…
1c119e3
…-count

remove extra lines in test file
0975c91

Merge branch 'main' into shuowei-anywidget-fallback-unknown-total-row…
61bd0aa
…-count

tswast reviewed Nov 17, 2025
View reviewed changes

Comment threadbigframes/display/anywidget.py

tswast reviewed Nov 17, 2025
View reviewed changes

shuoweil added 2 commits November 17, 2025 19:32

Merge branch 'main' into shuowei-anywidget-fallback-unknown-total-row…
49943ce
…-count

update how we handle negative page
cdd232c

shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2025

bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2025

shuoweil requested a review from tswast November 18, 2025 01:06

Merge branch 'main' into shuowei-anywidget-fallback-unknown-total-row…
2ce525a
…-count

tswast approved these changes Nov 18, 2025
View reviewed changes

tswast merged commit 508deae into mainNov 18, 2025
23 of 24 checks passed

tswast deleted the shuowei-anywidget-fallback-unknown-total-row-count branch November 18, 2025 19:23

GarrettWu mentioned this pull request Dec 3, 2025
chore: release 2.30.0 #2308
Merged

Navigation Menu

Uh oh!

fix: Improve Anywidget pagination and display for unknown row counts - #2258

fix: Improve Anywidget pagination and display for unknown row counts#2258
tswast merged 11 commits into
mainfrom
shuowei-anywidget-fallback-unknown-total-row-count

shuoweil commented Nov 12, 2025•
edited
Loading

Uh oh!

review-notebook-appBot commented Nov 12, 2025

Uh oh!

tswastNov 17, 2025

Uh oh!

shuoweilNov 17, 2025

Uh oh!

Uh oh!

tswastNov 17, 2025

Uh oh!

shuoweilNov 17, 2025

Uh oh!

tswastNov 17, 2025

Uh oh!

shuoweilNov 17, 2025

Uh oh!

shuoweil commented Nov 18, 2025

Uh oh!

tswast left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

shuoweil commented Nov 12, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

review-notebook-appBot commented Nov 12, 2025

Uh oh!

tswastNov 17, 2025

Choose a reason for hiding this comment

Uh oh!

shuoweilNov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tswastNov 17, 2025

Choose a reason for hiding this comment

Uh oh!

shuoweilNov 17, 2025

Choose a reason for hiding this comment

Uh oh!

tswastNov 17, 2025

Choose a reason for hiding this comment

Uh oh!

shuoweilNov 17, 2025

Choose a reason for hiding this comment

Uh oh!

shuoweil commented Nov 18, 2025

Uh oh!

tswast left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shuoweil commented Nov 12, 2025•
edited
Loading