Skip to content

fix: Improve strictness of nan vs None usage - #2326

Merged
tswast merged 2 commits into
mainfrom
equiv_util
Dec 12, 2025
Merged

fix: Improve strictness of nan vs None usage#2326
tswast merged 2 commits into
mainfrom
equiv_util

Conversation

@TrevorBergeron

@TrevorBergeronTrevorBergeron commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 11, 2025
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Dec 12, 2025
@TrevorBergeron
TrevorBergeron marked this pull request as ready for review December 12, 2025 18:09
@TrevorBergeron
TrevorBergeron requested review from a team and tswastDecember 12, 2025 18:09
tswast
tswast approved these changes Dec 12, 2025
View reviewed changes

@tswasttswast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment threadtests/system/small/test_dataframe.py
Comment on lines +3540 to +3541
# pandas 3.0 does not automatically ffill anymore
pd_result = scalars_pandas_df_index[col_names].ffill().pct_change(periods=periods)

@tswasttswastDec 12, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should put a bug for our bigframes 3.0 hotlist to change our pct_change behavior too.

@TrevorBergeronTrevorBergeronDec 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created issue 468354979

@tswast
tswast merged commit 481d938 into mainDec 12, 2025
24 of 25 checks passed
@tswast
tswast deleted the equiv_util branch December 12, 2025 18:27
@ldetmerldetmer mentioned this pull request Jan 6, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

Assignees

@shobsishobsi

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TrevorBergeron@tswast@shobsi