Skip to content

fix(deps): vendor sqlglot bigquery dialect and remove package dependency - #2354

Merged
tswast merged 9 commits into
mainfrom
main_chelsealin_sqlglot
Jan 2, 2026
Merged

fix(deps): vendor sqlglot bigquery dialect and remove package dependency#2354
tswast merged 9 commits into
mainfrom
main_chelsealin_sqlglot

Conversation

@chelsea-lin

@chelsea-linchelsea-lin commented Dec 23, 2025

Copy link
Copy Markdown
Contributor

Fixes internal issue 414417923🦕

@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 23, 2025
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_sqlglot branch from a9a0d8e to fe49168CompareDecember 23, 2025 04:05
@chelsea-lin
chelsea-lin marked this pull request as ready for review December 23, 2025 08:15
@chelsea-lin
chelsea-lin requested review from a teamDecember 23, 2025 08:16
@tswasttswast changed the title deps: vendor sqlglot codes and remove dependencyfix(deps): vendor sqlglot codes and remove dependencyDec 23, 2025
@tswasttswast changed the title fix(deps): vendor sqlglot codes and remove dependencyfix(deps): vendor sqlglot bigquery dialect and remove package dependencyDec 23, 2025
tswast
tswast reviewed Dec 23, 2025
View reviewed changes

@tswasttswast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the https://github.com/tobymao/sqlglot/blob/d7be4a5da3dca6bcc44230b2a176c8b17b81c46e/LICENSE file to third_party/bigframes_vendored/sqlglot/LICENSE.

Also, link to SQLGlot in https://github.com/googleapis/python-bigquery-dataframes/blob/main/README.rst#license

Comment threadthird_party/bigframes_vendored/sqlglot/typing/hive.py Outdated
Comment threadthird_party/bigframes_vendored/sqlglot/typing/presto.py Outdated
Comment threadthird_party/bigframes_vendored/sqlglot/typing/snowflake.py Outdated
Comment threadthird_party/bigframes_vendored/sqlglot/typing/spark2.py Outdated
Comment threadthird_party/bigframes_vendored/sqlglot/typing/tsql.py Outdated
Comment threadthird_party/bigframes_vendored/sqlglot/_typing.py Outdated
Comment threadthird_party/bigframes_vendored/sqlglot/expressions.py
Comment threadthird_party/bigframes_vendored/sqlglot/parser.py
@chelsea-lin
chelsea-linforce-pushed the main_chelsealin_sqlglot branch from d6ab6bc to d803af0CompareDecember 29, 2025 02:43
tswast
tswast approved these changes Jan 2, 2026
View reviewed changes

@tswasttswast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Chelsea!

@tswast
tswast merged commit b321d72 into mainJan 2, 2026
25 checks passed
@tswast
tswast deleted the main_chelsealin_sqlglot branch January 2, 2026 17:56
@ldetmerldetmer mentioned this pull request Jan 6, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

Assignees

@ZehaoXUZehaoXU

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chelsea-lin@tswast@ZehaoXU