Uh oh!
There was an error while loading. Please reload this page.
fix: bigframes.ml fit with eval data in partial mode avoids join on null index - #2355
Conversation
Modified `bigframes.ml.utils.combine_training_and_evaluation_data` to: 1. Join training `X` and `y` into a single DataFrame (and similarly for eval data) before concatenation. This ensures row identity/alignment is preserved through the concat operation, resolving issues where separate concats could drift apart in `ordering_mode="partial"`. 2. Operate on copies of input DataFrames to avoid side-effects (mutating user's input). 3. Safely handle column name collisions between `X` and `y` by temporarily renaming `y` columns during the join/merge process. This change fixes a bug where providing validation data to `fit()` could fail or produce incorrect results when using partial ordering mode.
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Modified `bigframes.ml.utils.combine_training_and_evaluation_data` to: 1. Join training `X` and `y` into a single DataFrame (and similarly for eval data) before concatenation. This ensures row identity/alignment is preserved through the concat operation, resolving issues where separate concats could drift apart in `ordering_mode="partial"`. 2. Operate on copies of input DataFrames to avoid side-effects (mutating user's input). 3. Safely handle column name collisions between `X` and `y` by temporarily renaming `y` columns during the join/merge process. Updated `tests/system/large/ml/test_linear_model.py`: - Parameterized `test_linear_regression_configure_fit_with_eval_score` to run with both `penguins_df_default_index` and `penguins_df_null_index` fixtures. - This ensures the fix is robust against different index configurations (default sequential vs potential null/arbitrary indices). This change fixes a bug where providing validation data to `fit()` could fail or produce incorrect results when using partial ordering mode.
tswast
commented
Dec 23, 2025
Tests pass locally: |
Uh oh!
There was an error while loading. Please reload this page.
Fix ML fit ordering issue with partial mode and eval data.
PR created automatically by Jules for task 4750522966926378079 started by @tswast