Skip to content

fix: avoid 403 response too large to return error with read_gbq and large query results - #77

Merged
gcf-merge-on-green[bot] merged 13 commits into
mainfrom
b303057336-403-too-large
Oct 3, 2023
Merged

fix: avoid 403 response too large to return error with read_gbq and large query results#77
gcf-merge-on-green[bot] merged 13 commits into
mainfrom
b303057336-403-too-large

Conversation

@tswast

@tswasttswast commented Oct 2, 2023

Copy link
Copy Markdown
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issue 303057336 🦕

@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 2, 2023
@tswast
tswast marked this pull request as ready for review October 3, 2023 16:13
@tswast
tswast requested review from a team, GarrettWu and liujiashang and removed request for liujiashangOctober 3, 2023 16:13
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 3, 2023
GarrettWu
GarrettWu approved these changes Oct 3, 2023
View reviewed changes
Comment threadbigframes/core/io.py Outdated
@tswasttswast added the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2023
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 8f3b5b2 into mainOct 3, 2023
@gcf-merge-on-green
gcf-merge-on-greenBot deleted the b303057336-403-too-large branch October 3, 2023 20:16
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2023
@release-pleaserelease-pleaseBot mentioned this pull request Oct 3, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@GarrettWuGarrettWuGarrettWu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast@GarrettWu