Skip to content

feat: add ml.preprocessing.KBinsDiscretizer - #81

Merged
ashleyxuu merged 9 commits into
mainfrom
ashleyxu-add-kbins-discretizer
Oct 4, 2023
Merged

feat: add ml.preprocessing.KBinsDiscretizer#81
ashleyxuu merged 9 commits into
mainfrom
ashleyxu-add-kbins-discretizer

Conversation

@ashleyxuu

@ashleyxuuashleyxuu commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ashleyxuu
ashleyxuu requested review from a team and milkshakeiiiOctober 2, 2023 23:12
@ashleyxuuashleyxuu self-assigned this Oct 2, 2023
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 2, 2023
GarrettWu
GarrettWu reviewed Oct 3, 2023
View reviewed changes
Comment threadbigframes/ml/compose.py Outdated
Comment threadbigframes/ml/sql.py Outdated
Comment threadbigframes/ml/preprocessing.py
Comment threadbigframes/ml/preprocessing.py
Comment threadbigframes/ml/preprocessing.py Outdated
Comment threadbigframes/ml/sql.py Outdated
Comment threadtests/system/small/ml/test_preprocessing.py Outdated
Comment threadtests/system/small/ml/test_preprocessing.py Outdated
Comment threadtests/unit/ml/test_sql.py Outdated
Comment threadthird_party/bigframes_vendored/sklearn/preprocessing/_discretization.py
GarrettWu
GarrettWu reviewed Oct 3, 2023
View reviewed changes
Comment threadbigframes/ml/preprocessing.py Outdated
Comment threadbigframes/ml/preprocessing.py Outdated
s = sql[sql.find("(") + 1 : sql.find(")")]
array_split_points = s[s.find("[") + 1 : s.find("]")]
col_label = s[: s.find(",")]
n_bins = array_split_points.count(",") + 1

@GarrettWuGarrettWuOct 3, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Comment threadbigframes/ml/preprocessing.py Outdated
@ashleyxuu
ashleyxuuforce-pushed the ashleyxu-add-kbins-discretizer branch from 4efcd9c to fbab743CompareOctober 3, 2023 18:22
@ashleyxuu
ashleyxuu merged commit 24c6256 into mainOct 4, 2023
@ashleyxuu
ashleyxuu deleted the ashleyxu-add-kbins-discretizer branch October 4, 2023 14:20
@release-pleaserelease-pleaseBot mentioned this pull request Oct 4, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@milkshakeiiimilkshakeiiiAwaiting requested review from milkshakeiii
1 more reviewer
@GarrettWuGarrettWuGarrettWu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@GarrettWuGarrettWu

@ashleyxuuashleyxuu

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ashleyxuu@GarrettWu