Skip to content

feat: implement bigframes.bigquery.json_extract_array - #910

Merged
shobsi merged 5 commits into
mainfrom
shobs-json-extract-array
Aug 23, 2024
Merged

feat: implement bigframes.bigquery.json_extract_array#910
shobsi merged 5 commits into
mainfrom
shobs-json-extract-array

Conversation

@shobsi

Copy link
Copy Markdown
Contributor

This is needed to implement support for array return types in remote functions.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

This id needed to implement support for array return types in remote
functions.
@shobsi
shobsi requested review from a team and chelsea-linAugust 21, 2024 17:42
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 21, 2024

@chelsea-linchelsea-lin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests are passed and left small comments can be addressed.

Comment threadbigframes/operations/__init__.py Outdated
Comment threadtests/system/small/bigquery/test_json.py
@shobsi
shobsi merged commit 575a29e into mainAug 23, 2024
@shobsi
shobsi deleted the shobs-json-extract-array branch August 23, 2024 06:56
@release-pleaserelease-pleaseBot mentioned this pull request Aug 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: mPull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@shobsi@chelsea-lin@TrevorBergeron