Skip to content

chore: temporarily disable struct accessor tests - #951

Closed
shobsi wants to merge 1 commit into
mainfrom
shobs-disable-explode-doctest
Closed

chore: temporarily disable struct accessor tests#951
shobsi wants to merge 1 commit into
mainfrom
shobs-disable-explode-doctest

Conversation

@shobsi

Copy link
Copy Markdown
Contributor

This is to unblock PRs until the real issue is identified and fixed in b/362738764.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

This is to unblock PRs until the real issue is identified and fixed in
b/362738764.
@shobsi
shobsi requested review from a team, Genesis929 and tswastSeptember 4, 2024 03:36
@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Sep 4, 2024
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Sep 4, 2024

@tswasttswast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doctest isn't a required check, so this feels unnecessary. Plus the doctest: +SKIP will end up in the API reference docs, which isn't ideal.

My understanding with conversation with @Genesis929 is that we can alphabetize the struct subfields in the sample data we create as a better temporary fix.

@tswast

Copy link
Copy Markdown
Collaborator

Closing in favor of #953 (review)

@tswasttswast closed this Sep 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@shobsi@tswast@mattyopl