fortigate firewall policy support

[Ali-aqrabawi]

in this pull request i added support for fortigate policies.

example .pol

header {
target:: fortigate from-id 2
target:: paloalto from-zone internal to-zone external
target:: juniper edge-filter
target:: cisco edge-filter
}
term allow-https-web {
destination-address:: WEB_SERVERS
destination-port:: WEB_SERVICES
protocol:: tcp
action:: accept
}
term customers-policy {
source-address:: CUSTOMERS
destination-address:: GOOGLE_PUBLIC_DNS_ANYCAST
destination-port:: WEB_SERVICES
protocol:: tcp
action:: deny
}
term customers-policy2 {
#source-interface:: wan1
#destination-interface:: wan2
source-address:: ALI_HOME
destination-address:: CRM
destination-port:: WEB_SERVICES
protocol:: tcp
action:: deny
logging:: true
}
term deny-any-any {
action:: deny
}
term deny-icmp {
action:: deny
protocol:: icmp
}
term accept-whois {
protocol:: udp
destination-port:: WHOIS
action:: accept
}

[ankenyr]

You will need to create tests for this before we can accept it. I provided a bunch of lint issues and a few general code comments. So far this is looking pretty good. Thank you for all the work on this!

[Ali-aqrabawi]

@ankenyr i have added unittest and resolved the code reviews.
for #173 (comment), i have create a Container object to hold the grouped commands like service-objects commands and network-objects commands

[ankenyr]

You will want to familiarize yourself with the style guide for python code owned by Google.
https://github.com/google/styleguide/blob/gh-pages/pyguide.md
80 characters is the maximum line length, indentation and line returns in correct places. Please review your code for adhereance to the standards. Resolve all comments that are outstanding and let me know when you are ready for the next pass through your code.

[ankenyr]

Hi Ali, I have not heard anything on this PR in a while. There are still pending changes requested.

[Ali-aqrabawi]

Hi Rob, i have done the requested changes here, did you check it?

[ankenyr]

sorry but I don't see the comments as resolved which is why I never checked on anything.
https://imgur.com/KwyGS0O
Can you make sure all the comments are resolved and then I can make another pass?

[Ali-aqrabawi]

done

[ankenyr]

Hey @Ali-aqrabawi did you have time to fix the remaining issues here?

[Ali-aqrabawi]

@ankenyr i'm working on it

[Ali-aqrabawi]

@ankenyr everything should be fixed now

[ankenyr]

This is looking good, just a few small nitpick changes. Sorry this review has lasted so long. I was on paternity for a while and then some hecktic work responding to covid stuff and family issues. If you can fix these quick I can pull this in asap.

[ankenyr]

Ali, there are still changes that have not been made that I have requested.

[Ali-aqrabawi]

Ali, there are still changes that have not been made that I have requested.

i checked the requested changes couple of times can't find which part i'm missing, sorry :/

[Slepwin]

Any updates here?

[nero85]

We are closing this in preference for #222. Thanks for your input!