Speculative fix for "No Target Architecture" error - #317
Merged
Merged
Conversation
This commit attempts to fix the build failure reported in google#316 (comment), which was a consequence of my previous commit [1]. With this commit relevant Win32 macros are overridden only while including <icu.h>. This commit also overrides _WIN32_WINNT to be consistent with NTDDI_VERSION. [1]: 2ebbe0d
derekmauro
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit attempts to fix the build failure reported in #316 (comment), which is a consequence of my previous commit (2ebbe0d).
With this commit relevant Win32 macros are overridden only while including
<icu.h>. This commit also overrides_WIN32_WINNTto be consistent withNTDDI_VERSION.