Add phone log flutter plugin - #1
Conversation
|
Hi @mehmetf, could please review this pr? Thanks! |
mehmetf
left a comment
There was a problem hiding this comment.
I just edited the .gitignore. I recommend syncing your client and creating a new PR. There's a lot of files in here that should not be part of the repo.
| build/ | ||
| ios/.generated/ | ||
| packages | ||
| pubspec.lock |
There was a problem hiding this comment.
You don't need this file. I just updated the .gitignore file at the root. That should be enough.
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2018 Jiaming Cheng | |||
There was a problem hiding this comment.
I believe you need to set this to Google Inc. Not your personal name.
| import 'package:phone_log/phone_log.dart'; | ||
| ``` | ||
|
|
||
| ### Methords |
| ### Methords | ||
| ```dart | ||
| /// Check phone log permission and return a [Future] with the result | ||
| static Future<bool> checkPermission(Permission permission); |
There was a problem hiding this comment.
Avoid static methods. This makes the plugin files non-mockable.
| @@ -0,0 +1,13 @@ | |||
| .DS_Store | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | ||
| package="com.example.phonelogexample"> | ||
|
|
||
| <!-- The INTERNET permission is required for development. Specifically, |
| <layer-list xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <item android:drawable="@android:color/white" /> | ||
|
|
||
| <!-- You can insert your own image assets here --> |
| @@ -0,0 +1,6 @@ | |||
| #Fri Jun 23 08:50:38 CEST 2017 | |||
There was a problem hiding this comment.
You only need this file. Revert everything else in this directorly. The updated .gitignore should handle all this.
| @@ -0,0 +1,44 @@ | |||
| .idea/ | |||
| @@ -0,0 +1,36 @@ | |||
| .idea/ | |||
|
Thanks a lot Mehmet. As you suggested I'm closing this one and pulling a new one with addressing all the comments. |
Hi team,
I just added a new plugin under the packages/...
Thanks,
Jiaming