Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

Cast methodChannel result type - #15

Merged
mehmetf merged 2 commits into
google:masterfrom
jiajiabingcheng:master
Oct 3, 2019
Merged

Cast methodChannel result type#15
mehmetf merged 2 commits into
google:masterfrom
jiajiabingcheng:master

Conversation

@jiajiabingcheng

@jiajiabingcheng jiajiabingcheng commented Oct 2, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot

googlebot commented Oct 2, 2019

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

mehmetf
mehmetf reviewed Oct 2, 2019
View reviewed changes
Comment thread packages/phone_log/lib/phone_log.dart Outdated
Future<bool> requestPermission() async {
final bool isGranted =
await _channel.invokeMethod("requestPermission", null);
await _channel.invokeMethod("requestPermission", null);

@mehmetf mehmetf Oct 2, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent problem.

@jiajiabingcheng jiajiabingcheng Oct 2, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Done.

@jiajiabingcheng jiajiabingcheng Oct 2, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please help merge these changes? Seems I don't have the access to merge prs to this repo.

@googlebot

googlebot commented Oct 3, 2019

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@mehmetf
mehmetf merged commit f5cca1b into google:master Oct 3, 2019
@mehmetf mehmetf mentioned this pull request Oct 3, 2019
Closed
@csacchetti csacchetti mentioned this pull request Jul 22, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mehmetf mehmetf mehmetf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiajiabingcheng @googlebot @mehmetf