Uh oh!
There was an error while loading. Please reload this page.
Ability added to use custom icons along with default icons in Node Le… - #451
Ability added to use custom icons along with default icons in Node Le…#451rajputvarun591 wants to merge 1 commit into
Conversation
jamesderlin
commented
Feb 10, 2023
Please see my comment on #447. Do not keep filing new PRs and closing them if you encounter a problem. |
rajputvarun591
commented
Feb 10, 2023
@jamesderlin Sorry for that bro. this is finally I have created with no issues. I will delete rest of the previous. |
rajputvarun591
commented
Feb 10, 2023
@jamesderlin I am very sorry to do that, actually it was my first time to make a PR on any of the plugin repository. I just was curious about it. Kindly delete the unwanted PR if you can or just decline them. Thank you for your support! |
rajputvarun591
commented
Feb 11, 2023
@jamesderlin And why so many PR's ? aren't you guys taking the changes from other dev? By when my PR will be merged and reflect the changes on pub.dev ? any idea about this? |
jamesderlin
commented
Feb 11, 2023
If you mean why are there so many unmerged PRs, this repository is the home to multiple packages, each owned by different individuals. Those individuals are responsible for maintaining their packages and for merging PRs. Some of those individuals might have moved on to other projects. |
rajputvarun591
commented
Feb 11, 2023
@jamesderlin Thanks for your quick response! I will contribute more features in the other packages too. and if it will be possible I will open the old PR by update code there, so that old PR's also been justified. Thanks for support. |
jamesderlin
commented
Feb 11, 2023
That would just be confusing. Just file new PRs for unrelated PRs from now on. |
| this.treeController}) | ||
| : nodes = copyTreeNodes(nodes), | ||
| /// This widget will be takes place of default icon when Node will not be in expanded state | ||
| final Widget? primaryIcon; |
| final Widget? primaryIcon; | ||
| /// This widget will be takes place of default icon when Node will be in expanded state | ||
| final Widget? secondaryIcon; |
| final Widget? primaryIcon; | ||
| /// This widget will be takes place of default icon when Node will be in expanded state | ||
| final Widget? secondaryIcon; |
There was a problem hiding this comment.
Here and in another one, make widget non-nullable and assign default value.
…ading.
Description
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.flutter testpass.flutter analyzedoes not report any problems on my PR.