feat: Add support for multiple writers for one query - #218
Merged
Conversation
Member
|
Hi @Vasist10, thanks for the contribution. Unfortunately, unit/test_config.py::test_save_returns_correct_data fails due to the proposed change. Apart from that I have a couple of comments:
|
Contributor
Author
|
@AndreyMarkinPPC i have unified the configuration for writer...and removed writers_parameters as suggested |
Member
|
@Vasist10 Thanks, looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for using multiple writers for a single query.
Now users can pass:
The executor now loops through all writer clients and runs each one.
Single-writer configs still work the same for backward compatibility.
issue - #193
I also added tests to confirm: