Skip to content

Remove graduated GitHub v3 API preview headers - #1618

Merged
gmlewis merged 1 commit into
google:masterfrom
vikkyomkar:issue-1616
Sep 17, 2020
Merged

Remove graduated GitHub v3 API preview headers#1618
gmlewis merged 1 commit into
google:masterfrom
vikkyomkar:issue-1616

Conversation

@vikkyomkar

@vikkyomkarvikkyomkar commented Aug 24, 2020

Copy link
Copy Markdown
Contributor

This PR addresses below issue
#1616

@google-clagoogle-claBot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Aug 24, 2020
@codecov

codecovBot commented Aug 24, 2020•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1618 into master will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #1618 +/- ##
==========================================
- Coverage 68.06% 67.92% -0.15% 
==========================================
Files 97 97 Lines 8855 8816 -39 ==========================================
- Hits 6027 5988 -39 
Misses 1912 1912 Partials 916 916
Impacted FilesCoverage Δ
github/apps.go58.87% <ø> (-3.63%)⬇️
github/apps_installation.go50.81% <ø> (-5.71%)⬇️
github/github.go90.02% <ø> (ø)
github/orgs.go69.07% <ø> (-0.63%)⬇️
github/issues.go73.52% <100.00%> (-1.48%)⬇️
github/issues_events.go51.02% <100.00%> (-0.98%)⬇️
github/pulls.go63.53% <100.00%> (-1.91%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57a3a8...7b9a88e. Read the comment docs.

gmlewis
gmlewis approved these changes Aug 27, 2020
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @vikkyomkar ! Thank you!
LGTM.

Awaiting second LGTM before merging.

@gmlewis
gmlewis requested a review from wesleimpAugust 27, 2020 12:53
@vikkyomkar

vikkyomkar commented Sep 17, 2020

Copy link
Copy Markdown
ContributorAuthor

@gmlewis can we get a 2nd review on this ?

@gmlewis

gmlewis commented Sep 17, 2020

Copy link
Copy Markdown
Collaborator

@wesleimp - do you have time for a review?
I believe we have a few outstanding PRs to look at when you have time.
Thank you!

wesleimp
wesleimp approved these changes Sep 17, 2020
View reviewed changes

@wesleimpwesleimp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vikkyomkar
LGTM 👌🏼

@gmlewis

gmlewis commented Sep 17, 2020

Copy link
Copy Markdown
Collaborator

Thank you, @wesleimp !
Merging.

@gmlewis
gmlewis merged commit 8e1859f into google:masterSep 17, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@vikkyomkar
Remove graduated GitHub v3 API preview headers (google#1618)
ae39d1c
Fixes: google#1616.
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Remove graduated GitHub v3 API preview headers (google#1618)
5caed6f
Fixes: google#1616.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
+1 more reviewer
@wesleimpwesleimpwesleimp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesIndication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vikkyomkar@gmlewis@wesleimp