Skip to content

Remove graduated GitHub v3 API preview header - #1636

Merged
gmlewis merged 2 commits into
google:masterfrom
n1lesh:checks-preview-header
Oct 4, 2020
Merged

Remove graduated GitHub v3 API preview header#1636
gmlewis merged 2 commits into
google:masterfrom
n1lesh:checks-preview-header

Conversation

@n1lesh

@n1leshn1lesh commented Oct 2, 2020

Copy link
Copy Markdown
Contributor

removed Accept header (with value mediaTypeCheckRunsPreview). Since checks run is out of preview, didn't see any value in keeping it.

Followed as per,

Graduation of preview: https://developer.github.com/changes/2020-10-01-graduate-antiope-preview/
Docs: https://docs.github.com/en/free-pro-team@latest/rest/reference/checks

@google-clagoogle-claBot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Oct 2, 2020
@codecov

codecovBot commented Oct 2, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1636 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #1636 +/- ##
==========================================
- Coverage 67.95% 67.87% -0.09% 
==========================================
Files 97 97 Lines 8824 8802 -22 ==========================================
- Hits 5996 5974 -22 
Misses 1912 1912 Partials 916 916 
Impacted FilesCoverage Δ
github/checks.go49.66% <ø> (-6.48%)⬇️
github/github.go90.02% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8da2410...25b4fbc. Read the comment docs.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @n1lesh , but this is the wrong approach.
We need to literally remove it, not replace it.

Please see https://github.com/google/go-github/pull/1618/files as a recent example of how this is done.

@n1leshn1lesh changed the title switch to mediaTypeV3 for ChecksRun Accept headerRemove graduated GitHub v3 API preview headerOct 3, 2020

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you, @n1lesh !
LGTM.

Awaiting second LGTM before merging.

@gmlewis
gmlewis requested a review from wesleimpOctober 3, 2020 14:38
@n1leshn1lesh closed this Oct 3, 2020
@n1leshn1lesh reopened this Oct 3, 2020

@nightlarknightlark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @nightlark !
Merging.

@gmlewis
gmlewis merged commit 76c3c3d into google:masterOct 4, 2020
@n1lesh
n1lesh deleted the checks-preview-header branch October 9, 2020 21:06
brackendawson added a commit to brackendawson/go-github that referenced this pull request Feb 22, 2022
gmlewis pushed a commit that referenced this pull request Feb 22, 2022
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesIndication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@n1lesh@gmlewis@nightlark