Skip to content

Repository.ListByOrg: Add nebula-preview to receive visibility field - #1795

Merged
gmlewis merged 1 commit into
google:masterfrom
marcelocarlos:support-visibility-list-by-org
Feb 5, 2021
Merged

Repository.ListByOrg: Add nebula-preview to receive visibility field#1795
gmlewis merged 1 commit into
google:masterfrom
marcelocarlos:support-visibility-list-by-org

Conversation

@marcelocarlos

Copy link
Copy Markdown
Contributor

What type of PR is this?

feature

What this PR does / why we need it:

In addition to the changes added in #1780, this change also ensures the Visibility field is included when calling Repositories.ListByOrg.

Special notes for your reviewer:

None

@google-cla

google-claBot commented Feb 5, 2021

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@marcelocarlos

Copy link
Copy Markdown
ContributorAuthor

@googlebot I signed it!

@google-clagoogle-claBot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Feb 5, 2021
@codecov

codecovBot commented Feb 5, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1795 (22cb4f1) into master (24b281b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #1795 +/- ##
=======================================
Coverage 97.54% 97.54% =======================================
Files 98 98 Lines 6383 6383 =======================================
Hits 6226 6226 Misses 85 85 Partials 72 72 
Impacted FilesCoverage Δ
github/repos.go98.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b281b...22cb4f1. Read the comment docs.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @marcelocarlos !
LGTM.
Merging.

@gmlewis
gmlewis merged commit 974597c into google:masterFeb 5, 2021
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesIndication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@marcelocarlos@gmlewis