Skip to content

Apps.ListRepos/Apps.ListUserRepos: Add mercy-preview + nebula-preview headers - #1806

Merged
gmlewis merged 1 commit into
google:masterfrom
andygrunwald:support-visibility-in-repo-app-list
Mar 5, 2021
Merged

Apps.ListRepos/Apps.ListUserRepos: Add mercy-preview + nebula-preview headers#1806
gmlewis merged 1 commit into
google:masterfrom
andygrunwald:support-visibility-in-repo-app-list

Conversation

@andygrunwald

Copy link
Copy Markdown
Contributor

What type of PR is this?

feature

What this PR does / why we need it:

  • mercy-preview: For receiving repository topics
  • nebula-preview: For visibility information

When calling Apps.ListRepos or Apps.ListUserRepos, the field visibility and topic are always nil.

The reason: Missing headers for developers preview API.

Special notes for your reviewer:

This applies the same fix as in #1780

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., usage docs, etc.:

… headers
* mercy-preview: For receiving repository topics
* nebula-preview: For visibility information
@google-clagoogle-claBot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Feb 21, 2021
@codecov

codecovBot commented Feb 21, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1806 (b535059) into master (5c87615) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #1806 +/- ##
=======================================
Coverage 97.59% 97.59% =======================================
Files 100 100 Lines 6521 6525 +4 =======================================
+ Hits 6364 6368 +4 
Misses 85 85 Partials 72 72 
Impacted FilesCoverage Δ
github/apps_installation.go91.30% <100.00%> (+0.82%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c87615...b535059. Read the comment docs.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @andygrunwald !
I've gone through the GitHub v3 API docs and can't find any mention of the nebula-preview custom header... why is that one needed? EDIT: Ah! I see you already covered this in your description... awesome. Thank you!

Otherwise, LGTM.

Awaiting second LGTM before merging.

@gmlewis

Copy link
Copy Markdown
Collaborator

Never mind my last comment. 😂 See edit above.

@wesleimpwesleimp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@andygrunwald

Copy link
Copy Markdown
ContributorAuthor

@gmlewis@wesleimp Good to merge? Anything I can do to support?

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @wesleimp !
Merging.

@gmlewis
gmlewis merged commit ed5a8f3 into google:masterMar 5, 2021
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesIndication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@andygrunwald@gmlewis@wesleimp