Skip to content

Support map type in go generate - #1867

Merged
gmlewis merged 2 commits into
google:masterfrom
gmlewis:i1866-support-map-go-generate
May 7, 2021
Merged

Support map type in go generate#1867
gmlewis merged 2 commits into
google:masterfrom
gmlewis:i1866-support-map-go-generate

Conversation

@gmlewis

Copy link
Copy Markdown
Collaborator

Fixes: #1866.

@google-clagoogle-claBot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label May 7, 2021
@codecov

codecovBot commented May 7, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1867 (9b05852) into master (85c1b28) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #1867 +/- ##
=======================================
Coverage 97.65% 97.65% =======================================
Files 105 105 Lines 6769 6771 +2 =======================================
+ Hits 6610 6612 +2 
Misses 86 86 Partials 73 73 
Impacted FilesCoverage Δ
github/strings.go100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85c1b28...9b05852. Read the comment docs.

@gmlewis
gmlewis requested a review from wesleimpMay 7, 2021 00:56

@wesleimpwesleimp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@gmlewis

Copy link
Copy Markdown
CollaboratorAuthor

Thank you, @wesleimp !
Merging.

@gmlewis
gmlewis merged commit a19996a into google:masterMay 7, 2021
@gmlewis
gmlewis deleted the i1866-support-map-go-generate branch May 7, 2021 13:33
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesIndication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

go generate broken when adding map[string]bool

2 participants

@gmlewis@wesleimp