Skip to content

Deprecate WebHookPayload - #2032

Merged
gmlewis merged 7 commits into
google:masterfrom
gmlewis:i-303-deprecate-WebHookPayload
Mar 25, 2022
Merged

Deprecate WebHookPayload#2032
gmlewis merged 7 commits into
google:masterfrom
gmlewis:i-303-deprecate-WebHookPayload

Conversation

@gmlewis

@gmlewisgmlewis commented Aug 6, 2021

Copy link
Copy Markdown
Collaborator

Fixes#303.

@google-clagoogle-claBot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Aug 6, 2021
@codecov

codecovBot commented Aug 6, 2021•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2032 (b82aaba) into master (3e8a7f0) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2032 +/- ##
==========================================
- Coverage 98.04% 98.04% -0.01% 
==========================================
Files 117 117 Lines 10460 10454 -6 ==========================================
- Hits 10256 10250 -6 
Misses 140 140 Partials 64 64
Impacted FilesCoverage Δ
github/event_types.go100.00% <ø> (ø)
github/repos_hooks.go100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8a7f0...b82aaba. Read the comment docs.

@gmlewis
gmlewis requested a review from wesleimpAugust 6, 2021 19:43
@gmlewis

gmlewis commented Aug 6, 2021

Copy link
Copy Markdown
CollaboratorAuthor
- Coverage 97.87% 97.87% -0.01%

This looks like a Codecov bug! Please ignore.

@me-dirume-diru mentioned this pull request Dec 24, 2021
Closed
@gmlewisgmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Mar 21, 2022
@gmlewis

gmlewis commented Mar 21, 2022

Copy link
Copy Markdown
CollaboratorAuthor

@dmitshur - when you have time (no rush), would you mind reviewing this PR since you commented on #303 ?

@gmlewis
gmlewis requested a review from dmitshurMarch 21, 2022 13:00
@gmlewisgmlewis added the NeedsReview PR is awaiting a review before merging. label Mar 25, 2022
dmitshur
dmitshur reviewed Mar 25, 2022
View reviewed changes

@dmitshurdmitshur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good, see two inline comments. One of them is a question.

Comment threadgithub/repos_hooks.go
Comment threadgithub/repos_hooks.go
dmitshur
dmitshur approved these changes Mar 25, 2022
View reviewed changes

@dmitshurdmitshur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Comment threadgithub/repos_hooks.go
Comment threadgithub/repos_hooks.go
@gmlewis

gmlewis commented Mar 25, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Thank you, @dmitshur !
Merging.

@gmlewis
gmlewis merged commit c28ccfd into google:masterMar 25, 2022
@gmlewis
gmlewis deleted the i-303-deprecate-WebHookPayload branch March 25, 2022 22:56
@gmlewisgmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 25, 2022
@gmlewisgmlewis mentioned this pull request Apr 30, 2022
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Deprecate WebHookPayload (google#2032)
d2ca0b7
Fixes: google#303 .
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitshurdmitshurdmitshur approved these changes
@wesleimpwesleimpAwaiting requested review from wesleimp

Assignees

No one assigned

Labels

Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).cla: yesIndication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate WebHookPayload

2 participants

@gmlewis@dmitshur