Skip to content

Update GitHub Pages API to add new response parameters - #2109

Merged
gmlewis merged 10 commits into
google:masterfrom
rreichel3:users/rreichel3/update-pages-api
Dec 3, 2021
Merged

Update GitHub Pages API to add new response parameters#2109
gmlewis merged 10 commits into
google:masterfrom
rreichel3:users/rreichel3/update-pages-api

Conversation

@rreichel3

Copy link
Copy Markdown
Contributor

This PR updates the GitHub Pages API structs to support the latest documented response from GitHub.

This fixes#2107

Its based upon the documentation on GitHub's public docs here and enables support for viewing a GitHub Pages' visibility and HTTPS configuration.

@google-clagoogle-claBot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Sep 28, 2021
@codecov

codecovBot commented Sep 28, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2109 (62a1c35) into master (b5776f9) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #2109 +/- ##
=======================================
Coverage 97.77% 97.78% =======================================
Files 111 112 +1 Lines 9934 9956 +22 =======================================
+ Hits 9713 9735 +22 
Misses 154 154 Partials 67 67 
Impacted FilesCoverage Δ
github/repos_pages.go97.11% <ø> (ø)
github/orgs_audit_log.go100.00% <0.00%> (ø)
github/apps_hooks.go100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5776f9...62a1c35. Read the comment docs.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rreichel3!
Just a few changes, please, and then we should be ready for a second LGTM before merging.

Comment threadgithub/repos_pages.go Outdated
Comment threadgithub/repos_pages.go Outdated
Comment threadgithub/repos_pages.go Outdated
Comment threadgithub/repos_pages.go Outdated
Comment threadgithub/repos_pages.go Outdated
Comment threadgithub/repos_pages.go Outdated
Comment threadgithub/repos_pages.go Outdated

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rreichel3 !
LGTM.

Awaiting second LGTM before merging.

@rreichel3

Copy link
Copy Markdown
ContributorAuthor

👋 @wesleimp Just wanted to bump this!

@cpanatocpanato left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks for this addition

@gmlewis

Copy link
Copy Markdown
Collaborator

Thank you, @cpanato !
Merging.

@gmlewis
gmlewis merged commit f262aa1 into google:masterDec 3, 2021
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesIndication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub Pages Response Out of Date

3 participants

@rreichel3@gmlewis@cpanato