Uh oh!
There was an error while loading. Please reload this page.
Update GitHub Pages API to add new response parameters - #2109
Conversation
Codecov Report
@@ Coverage Diff @@## master #2109 +/- ##
=======================================
Coverage 97.77% 97.78% =======================================
Files 111 112 +1 Lines 9934 9956 +22 =======================================
+ Hits 9713 9735 +22
Misses 154 154 Partials 67 67
Continue to review full report at Codecov.
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @rreichel3!
Just a few changes, please, and then we should be ready for a second LGTM before merging.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
…/rreichel3/go-github into users/rreichel3/update-pages-api
Uh oh!
There was an error while loading. Please reload this page.
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @rreichel3 !
LGTM.
Awaiting second LGTM before merging.
rreichel3
commented
Oct 15, 2021
👋 @wesleimp Just wanted to bump this! |
cpanato
left a comment
There was a problem hiding this comment.
lgtm
thanks for this addition
gmlewis
commented
Dec 3, 2021
Thank you, @cpanato ! |
This PR updates the GitHub Pages API structs to support the latest documented response from GitHub.
This fixes#2107
Its based upon the documentation on GitHub's public docs here and enables support for viewing a GitHub Pages' visibility and HTTPS configuration.