Skip to content

fix references to webhook types - #2224

Merged
gmlewis merged 1 commit into
google:masterfrom
iam-veeramalla:wt
Dec 8, 2021
Merged

fix references to webhook types#2224
gmlewis merged 1 commit into
google:masterfrom
iam-veeramalla:wt

Conversation

@iam-veeramalla

@iam-veeramallaiam-veeramalla commented Dec 8, 2021

Copy link
Copy Markdown
Contributor

Fixes: #2222.

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @iam-veeramalla !
LGTM.
Merging.

@codecov

codecovBot commented Dec 8, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2224 (b59fe0c) into master (7520506) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #2224 +/- ##
=======================================
Coverage 97.81% 97.81% =======================================
Files 112 112 Lines 10117 10117 =======================================
Hits 9896 9896 Misses 154 154 Partials 67 67 
Impacted FilesCoverage Δ
github/messages.go100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7520506...b59fe0c. Read the comment docs.

@gmlewis

Copy link
Copy Markdown
Collaborator

@googlebot update label

@iam-veeramalla

Copy link
Copy Markdown
ContributorAuthor

@googlebot update label

@gmlewis is there an issue with the bot ? Do I need to do something manually?

@gmlewis

Copy link
Copy Markdown
Collaborator

@iam-veeramalla - no, you don't need to do anything.
I was just hoping to get its attention to add the "CLA: yes" label to the issue just to avoid any future confusion.

@googlebot already approved the PR, but it neglected to add the label. I'll give it a little more time... and see if it wakes up.

@gmlewis

Copy link
Copy Markdown
Collaborator

OK, @googlebot, I gave you your chance. I'll add the label myself.

@gmlewisgmlewis added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Dec 8, 2021
@google-clagoogle-claBot removed the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Dec 8, 2021
@google-cla

google-claBot commented Dec 8, 2021

Copy link
Copy Markdown

☹️ Sorry, but only Googlers may change the label cla: yes.

@gmlewis

Copy link
Copy Markdown
Collaborator

frowning_face Sorry, but only Googlers may change the label cla: yes.

Ah, right. I remember that block of code. 😂

Too bad we didn't allow Xooglers to change the label. Oh well.

@iam-veeramalla

Copy link
Copy Markdown
ContributorAuthor

looks like the bot is playing around :p with us @gmlewis

@gmlewis
gmlewis merged commit ff33a55 into google:masterDec 8, 2021
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix the dead links for webhook event types

2 participants

@iam-veeramalla@gmlewis