Skip to content

Add app hook deliveries API - #2226

Merged
gmlewis merged 11 commits into
google:masterfrom
watchtowerai:app-hook-deliveries
Dec 16, 2021
Merged

Add app hook deliveries API#2226
gmlewis merged 11 commits into
google:masterfrom
watchtowerai:app-hook-deliveries

Conversation

@pierce-m

@pierce-mpierce-m commented Dec 13, 2021

Copy link
Copy Markdown

Resolves#2225

@pierce-m

pierce-m commented Dec 13, 2021

Copy link
Copy Markdown
Author

Can we re-run the cla job? I signed it but it hasn't updated 🤔

@gmlewis

gmlewis commented Dec 13, 2021

Copy link
Copy Markdown
Collaborator

@googlebot - recheck

gmlewis
gmlewis requested changes Dec 13, 2021
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pierce-m !
Just a few tweaks, please, then we should be ready for a second LGTM before merging.

Also, could you please send a message to @googlebot like "Hey @googlebot - I signed it." and let's see if it responds. Thanks again!

Comment threadgithub/apps_hooks_deliveries.go Outdated
Comment threadgithub/apps_hooks_deliveries.go Outdated
Comment threadgithub/apps_hooks_deliveries.go Outdated
Comment threadgithub/apps_hooks_deliveries_test.go
@gmlewisgmlewis changed the title App hook deliveries APIAdd app hook deliveries APIDec 13, 2021
@codecov

codecovBot commented Dec 13, 2021•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2226 (cca80b1) into master (ff33a55) will decrease coverage by 0.02%.
The diff coverage is 92.30%.

❗ Current head cca80b1 differs from pull request most recent head 2aa17ba. Consider uploading reports for the commit 2aa17ba to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@## master #2226 +/- ##
==========================================
- Coverage 97.81% 97.79% -0.03% 
==========================================
Files 112 113 +1 Lines 10117 10156 +39 ==========================================
+ Hits 9896 9932 +36 - Misses 154 156 +2 - Partials 67 68 +1
Impacted FilesCoverage Δ
github/apps_hooks_deliveries.go92.30% <92.30%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff33a55...2aa17ba. Read the comment docs.

Pierce McEntagartand others added 4 commits December 13, 2021 16:26
Pierce McEntagart@gmlewis
Update github/apps_hooks_deliveries.go
ae3ffa2
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Pierce McEntagart@gmlewis
Update github/apps_hooks_deliveries.go
01fb5eb
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Pierce McEntagart@gmlewis
Update github/apps_hooks_deliveries.go
7beecfa
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Pierce McEntagart@gmlewis
Update github/apps_hooks_deliveries_test.go
2aa17ba
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@pierce-m

pierce-m commented Dec 13, 2021

Copy link
Copy Markdown
Author

Looks like it updated with the new commits -- thanks!

gmlewis
gmlewis approved these changes Dec 13, 2021
View reviewed changes

@gmlewisgmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pierce-m !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@pierce-m

pierce-m commented Dec 16, 2021

Copy link
Copy Markdown
Author

@wesleimp can I get some 👀 on this one please?

@gmlewis

gmlewis commented Dec 16, 2021

Copy link
Copy Markdown
Collaborator

@Parker77 - do you have time to take a look at this one?

Parker77
Parker77 approved these changes Dec 16, 2021
View reviewed changes

@Parker77Parker77 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis

gmlewis commented Dec 16, 2021

Copy link
Copy Markdown
Collaborator

LGTM.

Thank you, @Parker77!
Merging.

@gmlewis
gmlewis merged commit 1d9884e into google:masterDec 16, 2021
@gmlewisgmlewis mentioned this pull request Jan 13, 2022
Merged
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
@jlaportebot
Add app hook deliveries API (google#2226)
ce4d769
Fixes: google#2225.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewisgmlewisgmlewis approved these changes
@wesleimpwesleimpAwaiting requested review from wesleimp
+1 more reviewer
@Parker77Parker77Parker77 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

List/Get/Redeliver App Webhook Deliveries

3 participants

@pierce-m@gmlewis@Parker77