Uh oh!
There was an error while loading. Please reload this page.
adding examples for app auth - #2240
Conversation
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @patalwell !
Just a few minor tweaks, please.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
patalwell
commented
Dec 27, 2021
@gmlewis good to go! |
gmlewis
commented
Dec 27, 2021
I'm not seeing any changes since my last review... did you push them? Also, did you run
|
Codecov Report
@@ Coverage Diff @@## master #2240 +/- ##
=======================================
Coverage 97.80% 97.80% =======================================
Files 113 113 Lines 10205 10205 =======================================
Hits 9981 9981 Misses 156 156 Partials 68 68 Continue to review full report at Codecov.
|
patalwell
commented
Dec 29, 2021
@gmlewis oops, wrong branch. Pushed to the right one this time. Made the logging changes. I didn't want to run mod tidy since we ran into issues last time with the go.mod file and go.sum files, BUT ran the commands at your discretion :) Ran a test as well, I originally never ran one since I didn't have a test file. Also ran a linter! there was an error with one of the imports, so ran |
Uh oh!
There was an error while loading. Please reload this page.
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @patalwell !
LGTM.
Awaiting second LGTM from any other contributor to this repo before merging.
patalwell
commented
Dec 31, 2021
@wesleimp mind taking a look at these changes? |
patalwell
commented
Jan 3, 2022
Happy New Year! @gmlewis Hey so dont want to lose any momentum here, anyway we can ping another commiter for review? |
gmlewis
commented
Jan 3, 2022
Happy New Year to you too, @patalwell ! Maybe @Parker77 has time to review. |
gmlewis
commented
Jan 3, 2022
Thank you, @Parker77 ! |
@gmlewis opened a seperate PR from master, have a headache from trying to revert fetches I had pulled. I'd have to cherry pick commits and would rather start fresh.
To recap, this is a simple change to README.md and an example for GitHub app authentication flow so folks can understand how to leverage installations and access tokens.