Uh oh!
There was an error while loading. Please reload this page.
Update .gitignore for ignoring goenv .go-version file - #2242
Merged
Conversation
siansiansu
commented
Dec 27, 2021
ContributorAuthor
I have signed the CLA, please help to re-run it if approved. |
gmlewis
requested changes
Dec 27, 2021
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @siansiansu !
Let's please make the comment a bit more useful.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #2242 +/- ##
=======================================
Coverage 97.80% 97.80% =======================================
Files 113 113 Lines 10205 10205 =======================================
Hits 9981 9981 Misses 156 156 Partials 68 68 Continue to review full report at Codecov.
|
gmlewis
approved these changes
Dec 27, 2021
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @siansiansu !
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi reviewers:
I updated the
.gitignoreto ignore the.go-versionfile in this PR.If merged, it's easy to manage different go version locally for the goenv user.
Please help to review it. Thanks!
Reference
https://github.com/syndbg/goenv/blob/master/COMMANDS.md#goenv-local